Bump main version to 9.0-alpha1 #90558

carlossanlop · 2023-08-15T00:20:25Z

🎉

ghost · 2023-08-15T00:20:37Z

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

🎉

Author:	carlossanlop
Assignees:	carlossanlop
Labels:	`area-Infrastructure`
Milestone:	9.0.0

carlossanlop · 2023-08-15T01:20:12Z

@dotnet/ncl or @ViktorHofer do you know how to address the Quic failure message about opting into preview features?:

src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http3Connection.cs(29,37): error CA2252: (NETCORE_ENGINEERING_TELEMETRY=Build) '_activeRequests''s type contains the preview type 'QuicStream' and requires opting into preview features. See https://aka.ms/dotnet-warnings/preview-features for more information. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2252)

wfurt · 2023-08-15T01:47:41Z

Strange, HTTP already has the preview feature set:

runtime/src/libraries/System.Net.Http/src/System.Net.Http.csproj

Line 6 in 333c2c7

Perhaps something in the SDK?

BTW This may also break the Enterprise pipeline - at least it always did in the past.

jkoritzinsky · 2023-08-15T02:19:51Z

EnablePreviewFeatures has an interesting behavior that it only works on the most current TFM. Looks like we might need some other solution here.

wfurt · 2023-08-15T02:24:02Z

removing RequiresPreviewFeaturesAttribute from Quic for now? I would hope nobody would use 9.0 in production yet.

jkoritzinsky · 2023-08-15T02:57:14Z

Maybe manually including the attribute in the .NET 8 build (instead of using the SDK property) would work.

antonfirsov · 2023-08-15T20:14:45Z

/azp-run runtime-libraries stress-http

antonfirsov · 2023-08-15T20:15:02Z

/azp-run runtime-libraries enterprise-linux

jkoritzinsky · 2023-08-16T00:44:05Z

@carlossanlop @wfurt I looked more into the failure. Here's whats happening:

We have infrastructure to automatically say that for <MajorVersion>N</MajorVersion>, the latest TFM is netN.0.
This PR updates MajorVersion to 9.
This PR does not update NetCoreAppCurrent to net9.0.
As a result, System.Net.Http is building for net8.0.
The SDK isn't applying the EnablePreviewFeatures attribute as net8.0 is no longer the "latest TFM".

There are two possible solutions:

Manually include the EnablePreviewFeatures attribute until we change NetCoreAppCurrent.
Change NetCoreAppCurrent (and NetCoreAppMinimum and NetCoreAppPrevious as well) now and face the problems that come with that now.

@carlossanlop which would you rather do? I'd prefer the second option personally.

jkoritzinsky · 2023-08-16T03:50:46Z

I've started down the path of the second option locally. I'll try to finish it up tomorrow so I can push it out (just fixing up APICompat baselining).

…void regressions in .NET 8.0 targets and clean up .NET 8->.NET 9 API compat baselining.

…n the 9.0 variants of the packages.

jkoritzinsky · 2023-08-21T19:04:38Z

PR with the TFM upgrade is at #90880

Thank you so much, @jkoritzinsky, that is a huge contribution. I think it's best to send it separately.

I agree. This PR only has the changes required for the rebranding, not the TFM upgrade.

…convert Version=8.0.0.0 to Version=9.0.0.0)

ViktorHofer · 2023-08-21T19:16:16Z

src/libraries/System.Linq.Expressions/src/CompatibilitySuppressions.xml

@@ -139,6 +139,48 @@
    <Left>ref/net8.0/System.Linq.Expressions.dll</Left>
    <Right>lib/net8.0/System.Linq.Expressions.dll</Right>
  </Suppression>
+  <Suppression>


These changes should be reverted. Same for the test binary file below.

The build fails without these two changes.

…s passing.

* Adding PACKAGE.md to System.Runtime.Caching package * add Remarks * move PACKAGE.md to src folder * update per PR feedback * add important block

radical · 2023-08-21T22:16:15Z

New sdk error on windows:

EXEC : error : dotnet-install: Failed to check the disk space. Installation will continue, but it may fail if you do not have [D:\a\_work\1\s\src\mono\wasm\Wasm.Build.Tests\Wasm.Build.Tests.csproj]
##[error]EXEC(0,0): error : (NETCORE_ENGINEERING_TELEMETRY=Build) dotnet-install: Failed to check the disk space. Installation will continue, but it may fail if you do not have
   enough disk space.
  dotnet-install: Extracting the archive.

The log doesn't show the exit code. I'll check locally.

radical · 2023-08-22T01:01:14Z

New sdk error on windows:

EXEC : error : dotnet-install: Failed to check the disk space. Installation will continue, but it may fail if you do not have [D:\a\_work\1\s\src\mono\wasm\Wasm.Build.Tests\Wasm.Build.Tests.csproj]
##[error]EXEC(0,0): error : (NETCORE_ENGINEERING_TELEMETRY=Build) dotnet-install: Failed to check the disk space. Installation will continue, but it may fail if you do not have
   enough disk space.
  dotnet-install: Extracting the archive.

The log doesn't show the exit code. I'll check locally.

I'm not sure what is wrong here. The dotnet-install.ps1 script uses Write-Warning to emit the message, and this script is being run with Exec msbuild task with IgnoreStandardErrorWarningFormat="true". I don't know how it is becoming an error. The task doesn't even seem to fail the build, and instead the whole build completes, and then msbuild shows the error at the end.

Update: the warning is emitted if the powershell version is < 7.

ViktorHofer

The AssemblyVersion property in Versions.props must be hardcoded to 8.0.0.0 for now. We had the same issue last release and noticed that updating the TFM must happen in conjunction with reving the major assembly version.

Please also undo the changes in both CompatibilitySuppressions.xml, the TestData.resources one and the PACKAGE.md change which looks unrelated.

Prompted by the following getting caught as a warning, and converted to an error: ``` EXEC : error : dotnet-install: Failed to check the disk space. Installation will continue, but it may fail if you do not have [D:\a\_work\1\s\src\mono\wasm\Wasm.Build.Tests\Wasm.Build.Tests.csproj] enough disk space. dotnet-install: Extracting the archive. ```

radical · 2023-08-22T15:00:47Z

this script is being run with Exec msbuild task with IgnoreStandardErrorWarningFormat="true".

This was missing for the windows case!

This reverts commit 1b9e4e3.

radical · 2023-08-22T20:46:32Z

/azp run runtime-wasm

azure-pipelines · 2023-08-22T20:46:44Z

Azure Pipelines successfully started running 1 pipeline(s).

jkoritzinsky · 2023-08-23T00:11:26Z

@radical if the WASM MT failures are known, can you merge this in?

Bump main version to 9.0-alpha1

dc67073

carlossanlop added the area-Infrastructure label Aug 15, 2023

carlossanlop added this to the 9.0.0 milestone Aug 15, 2023

carlossanlop requested review from ViktorHofer, mmitche and ericstj August 15, 2023 00:20

carlossanlop self-assigned this Aug 15, 2023

carlossanlop requested review from lewing and steveisok August 15, 2023 00:21

build-analysis bot mentioned this pull request Aug 15, 2023

Intermittent build failure in AfterSourceBuild: "Could not write state file" #76488

Open

mmitche approved these changes Aug 15, 2023

View reviewed changes

Try bumping SdkBandVersion

4137b9c

lewing added 2 commits August 15, 2023 15:28

Bump the emscripten transport package

596c541

Fix typo

0ff0b4b

build-analysis bot mentioned this pull request Aug 16, 2023

Tracking issue for CI build timeouts #76454

Closed

jkoritzinsky added 2 commits August 16, 2023 11:47

Update TFM to net9.0, minimum to net8.0, use RC1 nightly for SDK to a…

9f1049a

…void regressions in .NET 8.0 targets and clean up .NET 8->.NET 9 API compat baselining.

Add compat suppressions for removed EOL TFM assets that will not be i…

eb1aeb7

…n the 9.0 variants of the packages.

jkoritzinsky requested review from marek-safar, pavelsavara and MichalStrehovsky as code owners August 16, 2023 19:11

Patch preserialized resources to account for the major version bump (…

50f3771

…convert Version=8.0.0.0 to Version=9.0.0.0)

ViktorHofer reviewed Aug 21, 2023

View reviewed changes

jkoritzinsky and others added 4 commits August 21, 2023 13:41

Suppress EventLog package validation failures to get allconfiguration…

3413966

…s passing.

Fix queue count in rate limiters (#90810)

30f1200

Adding PACKAGE.md to System.Runtime.Caching package (#90701)

2721f80

* Adding PACKAGE.md to System.Runtime.Caching package * add Remarks * move PACKAGE.md to src folder * update per PR feedback * add important block

[wasm] Unpin sdk version, and change channel to 9.0 for WBT

dbcf346

ViktorHofer reviewed Aug 22, 2023

View reviewed changes

jkoritzinsky added 6 commits August 22, 2023 10:39

Force AssemblyVersion

60366ef

Revert changes.

6717aa8

Remove the SLE suppressions again.

26eb430

Fix 9.0->8.0 replace

578df91

Revert "Fix queue count in rate limiters (#90810)"

92785ac

This reverts commit 1b9e4e3.

Fix formatting

00ba089

build-analysis bot mentioned this pull request Aug 22, 2023

tracing/runtimeeventsource/nativeruntimeeventsource/nativeruntimeeventsource failing in CI #90605

Open

ViktorHofer approved these changes Aug 22, 2023

View reviewed changes

radical mentioned this pull request Aug 22, 2023

[wasm] Add a dependency on dotnet/installer to get the latest #90904

Merged

Update Version.Details.xml for xlifftasks to try to fix prebuilt error.

23468ad

radical merged commit 96c2e1d into main Aug 23, 2023
192 of 195 checks passed

radical deleted the BumpMainTo90Alpha1 branch August 23, 2023 00:15

build-analysis bot mentioned this pull request Aug 23, 2023

[wasm] DebuggerTests.MiscTests.DebuggerTests.MiscTests.TestDebugUsingMultiThreadedRuntime failing #89909

Open

LoopedBard3 mentioned this pull request Aug 23, 2023

Wasm runs failing due to browser wasm sdk being 9.0.0 dotnet/performance#3292

Closed

ghost locked as resolved and limited conversation to collaborators Sep 22, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump main version to 9.0-alpha1 #90558

Bump main version to 9.0-alpha1 #90558

carlossanlop commented Aug 15, 2023

ghost commented Aug 15, 2023

carlossanlop commented Aug 15, 2023

wfurt commented Aug 15, 2023

jkoritzinsky commented Aug 15, 2023

wfurt commented Aug 15, 2023

jkoritzinsky commented Aug 15, 2023

antonfirsov commented Aug 15, 2023

antonfirsov commented Aug 15, 2023

jkoritzinsky commented Aug 16, 2023

jkoritzinsky commented Aug 16, 2023

jkoritzinsky commented Aug 21, 2023

ViktorHofer Aug 21, 2023 •

edited

Loading

jkoritzinsky Aug 21, 2023

radical commented Aug 21, 2023

radical commented Aug 22, 2023 •

edited

Loading

ViktorHofer left a comment

radical commented Aug 22, 2023

radical commented Aug 22, 2023

azure-pipelines bot commented Aug 22, 2023

jkoritzinsky commented Aug 23, 2023

Bump main version to 9.0-alpha1 #90558

Bump main version to 9.0-alpha1 #90558

Conversation

carlossanlop commented Aug 15, 2023

ghost commented Aug 15, 2023

carlossanlop commented Aug 15, 2023

wfurt commented Aug 15, 2023

jkoritzinsky commented Aug 15, 2023

wfurt commented Aug 15, 2023

jkoritzinsky commented Aug 15, 2023

antonfirsov commented Aug 15, 2023

antonfirsov commented Aug 15, 2023

jkoritzinsky commented Aug 16, 2023

jkoritzinsky commented Aug 16, 2023

jkoritzinsky commented Aug 21, 2023

ViktorHofer Aug 21, 2023 • edited Loading

Choose a reason for hiding this comment

jkoritzinsky Aug 21, 2023

Choose a reason for hiding this comment

radical commented Aug 21, 2023

radical commented Aug 22, 2023 • edited Loading

ViktorHofer left a comment

Choose a reason for hiding this comment

radical commented Aug 22, 2023

radical commented Aug 22, 2023

azure-pipelines bot commented Aug 22, 2023

jkoritzinsky commented Aug 23, 2023

ViktorHofer Aug 21, 2023 •

edited

Loading

radical commented Aug 22, 2023 •

edited

Loading