[Blazor] Remove unnecessary update to the Blazor webassembly js file #50949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiercn
force-pushed
the
javiercn/fix-blazor-hard-fingerprinting-magic-behavior
branch
2 times, most recently
from
ea052a7 to
faec67a
Compare
maraf
approved these changes
Sep 22, 2025
This was referenced Sep 22, 2025
javiercn
force-pushed
the
javiercn/fix-blazor-hard-fingerprinting-magic-behavior
branch
from
5146603 to
52ca4a7
Compare
lewing
approved these changes
Sep 22, 2025
javiercn
force-pushed
the
javiercn/fix-blazor-hard-fingerprinting-magic-behavior
branch
2 times, most recently
from
93b1cc7 to
9c74276
Compare
javiercn
force-pushed
the
javiercn/fix-blazor-hard-fingerprinting-magic-behavior
branch
from
9c74276 to
0dc4703
Compare
I see the same failure on an unrelated pr https://github.com/dotnet/sdk/pull/50948/checks?check_run_id=50914392897 so I'm comfortable it is not related to this change. I do wonder when it regressed though. cc @marcpopMSFT |
3 tasks
|
/backport to release/10.0.1xx-rc2 |
|
Started backporting to release/10.0.1xx-rc2: https://github.com/dotnet/sdk/actions/runs/17931765331 |
javiercn
deleted the
javiercn/fix-blazor-hard-fingerprinting-magic-behavior
branch
1 task
4 tasks
Merged
4 tasks
This was referenced Oct 14, 2025
Merged
|
/backport to main |
|
Started backporting to main: https://github.com/dotnet/sdk/actions/runs/18536167192 |
lewing
added a commit
to dotnet/runtime
that referenced
this pull request
Oct 17, 2025
…ng (#120746) Backport of #120694 to release/10.0 In dotnet/sdk#50949 we changed the identity of StaticWebAsset to contain fingerprint (dotnet.native.wasm -> dotnet.native.FP.wasm). This PR accommodates this when checking for dotnet.native.wasm asset from build. The SDK change didn't flown to the runtime yet, and so Wasm.Build.Tests won't test it yet. Fixes dotnet/aspnetcore#64011 /cc @maraf ## Customer Impact - [ ] Customer reported - [x] Found internally [[Select one or both of the boxes. Describe how this issue impacts customers, citing the expected and actual behaviors and scope of the issue. If customer-reported, provide the issue number.]](dotnet/aspnetcore#64011) ## Regression - [x] Yes - [ ] No Introduced in dotnet/sdk#50949 which added a fingerprint to the msbuild item identity ## Testing Manual and automated tests. ## Risk Low. The change are very scoped to target and items used only by preloading. **IMPORTANT**: If this backport is for a servicing release, please verify that: - The PR target branch is `release/X.0-staging`, not `release/X.0`. ## Package authoring no longer needed in .NET 9 **IMPORTANT**: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version. Keep in mind that we still need package authoring in .NET 8 and older versions. --------- Co-authored-by: Marek Fišera <mara@neptuo.com> Co-authored-by: Larry Ewing <lewing@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Blazor] Remove unnecessary update to the Blazor webassembly js file
Remove redundant blazor.webassembly.js update that broke publish
Description
Hosted webassembly apps failed to publish due to a bug in how we were trying to update the
blazor.webassembly.jsasset definition. We realized that we did not have to do so, but that there was a bug precluding us from finding the asset during the publish process.The fix corrects the identity of the blazor.webassembly.js to account for the fingerprint for the file we introduced in 10.0, which wasn't being taken into account.
Fixes #119886
Customer Impact
Customers with a hosted Blazor WebAssembly + Web API (Server) solution failed to publish. There is no straightforward user workaround short of editing writing a significant amount of MSBuild to work around the issue.
Regression?
Regressed from .NET 8 (publishing the same project type succeeded in 8.x).
Risk
Justification: The change only removes an unnecessary build step and fixes a case that was exclusively related to Blazor webassembly. It does not alter the contents of the delivered script, pipeline ordering, or introduce new logic— it simply stops creating an anomalous asset entry. Existing publish & static web asset tests still apply. Low surface area and isolated to Blazor WASM publish scenario.
Verification
Packaging changes reviewed?