Skip to content

Comments

[main] Source code updates from dotnet/dotnet#52596

Closed
dotnet-maestro[bot] wants to merge 20 commits intomainfrom
darc-main-d609ca50-a993-45de-91e5-6aada7cde00a
Closed

[main] Source code updates from dotnet/dotnet#52596
dotnet-maestro[bot] wants to merge 20 commits intomainfrom
darc-main-d609ca50-a993-45de-91e5-6aada7cde00a

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jan 21, 2026

Note

This is a codeflow update. It may contain both source code changes from
the VMR
as well as dependency updates. Learn more here.

This pull request brings the following source code changes

From https://github.com/dotnet/dotnet

Updated Dependencies

  • From 11.0.0-preview.1.26069.105 to 11.0.0-preview.1.26071.101
    • dotnet-dev-certs
    • dotnet-user-jwts
    • dotnet-user-secrets
    • Microsoft.AspNetCore.Analyzers
    • Microsoft.AspNetCore.App.Ref
    • Microsoft.AspNetCore.App.Ref.Internal
    • Microsoft.AspNetCore.Authentication.Facebook
    • Microsoft.AspNetCore.Authentication.Google
    • Microsoft.AspNetCore.Authentication.MicrosoftAccount
    • Microsoft.AspNetCore.Authorization
    • Microsoft.AspNetCore.Components
    • Microsoft.AspNetCore.Components.Analyzers
    • Microsoft.AspNetCore.Components.Forms
    • Microsoft.AspNetCore.Components.SdkAnalyzers
    • Microsoft.AspNetCore.Components.Web
    • Microsoft.AspNetCore.Components.WebAssembly
    • Microsoft.AspNetCore.Components.WebAssembly.Server
    • Microsoft.AspNetCore.Components.WebView
    • Microsoft.AspNetCore.DeveloperCertificates.XPlat
    • Microsoft.AspNetCore.Metadata
    • Microsoft.AspNetCore.Mvc.Analyzers
    • Microsoft.AspNetCore.Mvc.Api.Analyzers
    • Microsoft.AspNetCore.TestHost
    • Microsoft.Bcl.AsyncInterfaces
    • Microsoft.DotNet.Web.ItemTemplates.11.0
    • Microsoft.DotNet.Web.ProjectTemplates.11.0
    • Microsoft.Dotnet.WinForms.ProjectTemplates
    • Microsoft.DotNet.Wpf.ProjectTemplates
    • Microsoft.Extensions.Configuration.Ini
    • Microsoft.Extensions.DependencyModel
    • Microsoft.Extensions.FileProviders.Abstractions
    • Microsoft.Extensions.FileProviders.Embedded
    • Microsoft.Extensions.FileSystemGlobbing
    • Microsoft.Extensions.Logging
    • Microsoft.Extensions.Logging.Abstractions
    • Microsoft.Extensions.Logging.Console
    • Microsoft.Extensions.ObjectPool
    • Microsoft.JSInterop
    • Microsoft.NET.HostModel
    • Microsoft.NET.ILLink.Tasks
    • Microsoft.NET.Runtime.Emscripten.3.1.56.Cache.win-x64
    • Microsoft.NET.Sdk.WindowsDesktop
    • Microsoft.NETCore.App.Ref
    • Microsoft.NETCore.Platforms
    • Microsoft.Win32.SystemEvents
    • Microsoft.WindowsDesktop.App.Internal
    • Microsoft.WindowsDesktop.App.Ref
    • System.CodeDom
    • System.ComponentModel.Composition
    • System.Composition.AttributedModel
    • System.Composition.Convention
    • System.Composition.Hosting
    • System.Composition.Runtime
    • System.Composition.TypedParts
    • System.Configuration.ConfigurationManager
    • System.Diagnostics.DiagnosticSource
    • System.Formats.Asn1
    • System.IO.Hashing
    • System.Reflection.MetadataLoadContext
    • System.Resources.Extensions
    • System.Security.Cryptography.Pkcs
    • System.Security.Cryptography.ProtectedData
    • System.Security.Cryptography.Xml
    • System.Security.Permissions
    • System.ServiceProcess.ServiceController
    • System.Text.Encoding.CodePages
    • System.Text.Json
    • System.Windows.Extensions
  • From 10.0.0-preview.26069.105 to 10.0.0-preview.26071.101
    • Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal
    • Microsoft.CodeAnalysis.Razor.Tooling.Internal
    • Microsoft.NET.Sdk.Razor.SourceGenerators.Transport
  • From 18.4.0-preview-26069-105 to 18.4.0-preview-26071-101
    • Microsoft.Build
    • Microsoft.Build.Localization
  • From 7.3.0-preview.1.7005 to 7.3.0-preview.1.7201
    • Microsoft.Build.NuGetSdkResolver
    • NuGet.Build.Tasks
    • NuGet.Build.Tasks.Console
    • NuGet.Build.Tasks.Pack
    • NuGet.CommandLine.XPlat
    • NuGet.Commands
    • NuGet.Common
    • NuGet.Configuration
    • NuGet.Credentials
    • NuGet.DependencyResolver.Core
    • NuGet.Frameworks
    • NuGet.LibraryModel
    • NuGet.Localization
    • NuGet.Packaging
    • NuGet.ProjectModel
    • NuGet.Protocol
    • NuGet.Versioning
  • From 11.0.100-preview.26069.105 to 11.0.100-preview.26071.101
    • Microsoft.Build.Tasks.Git
    • Microsoft.SourceLink.AzureRepos.Git
    • Microsoft.SourceLink.Bitbucket.Git
    • Microsoft.SourceLink.Common
    • Microsoft.SourceLink.GitHub
    • Microsoft.SourceLink.GitLab
  • From 5.4.0-2.26069.105 to 5.4.0-2.26071.101
    • Microsoft.CodeAnalysis
    • Microsoft.CodeAnalysis.BuildClient
    • Microsoft.CodeAnalysis.CSharp
    • Microsoft.CodeAnalysis.CSharp.CodeStyle
    • Microsoft.CodeAnalysis.CSharp.Features
    • Microsoft.CodeAnalysis.CSharp.Workspaces
    • Microsoft.CodeAnalysis.ExternalAccess.HotReload
    • Microsoft.CodeAnalysis.PublicApiAnalyzers
    • Microsoft.CodeAnalysis.Workspaces.Common
    • Microsoft.CodeAnalysis.Workspaces.MSBuild
    • Microsoft.Net.Compilers.Toolset
    • Microsoft.Net.Compilers.Toolset.Framework
  • From 2.0.0-preview.1.26069.105 to 2.0.0-preview.1.26071.101
    • Microsoft.Deployment.DotNet.Releases
  • From 3.0.0-preview.26069.105 to 3.0.0-preview.26071.101
    • Microsoft.DiaSymReader
  • From 11.0.0-beta.26069.105 to 11.0.0-beta.26071.101
    • Microsoft.DotNet.Arcade.Sdk
    • Microsoft.DotNet.Build.Tasks.Installers
    • Microsoft.DotNet.Build.Tasks.Templating
    • Microsoft.DotNet.Build.Tasks.Workloads
    • Microsoft.DotNet.Helix.Sdk
    • Microsoft.DotNet.SignTool
    • Microsoft.DotNet.XliffTasks
    • Microsoft.DotNet.XUnitExtensions
  • From 15.2.100-preview.26069.105 to 15.2.100-preview.26071.101
    • Microsoft.FSharp.Compiler
  • From 18.3.0-preview-26069-105 to 18.4.0-preview-26071-101
    • Microsoft.NET.Test.Sdk
    • Microsoft.TestPlatform.Build
    • Microsoft.TestPlatform.CLI
  • From 11.0.100-preview.1.26069.105 to 11.0.100-preview.1.26071.101
    • Microsoft.TemplateEngine.Abstractions
    • Microsoft.TemplateEngine.Authoring.TemplateVerifier
    • Microsoft.TemplateEngine.Edge
    • Microsoft.TemplateEngine.Mocks
    • Microsoft.TemplateEngine.Orchestrator.RunnableProjects
    • Microsoft.TemplateEngine.TestHelper
    • Microsoft.TemplateEngine.Utils
    • Microsoft.TemplateSearch.Common
    • Microsoft.TemplateSearch.TemplateDiscovery
  • From 3.3.0-preview.26069.105 to 3.3.0-preview.26071.101
    • Microsoft.Web.Xdt
  • From 3.0.0-preview.1.26069.105 to 3.0.0-preview.1.26071.101
    • System.CommandLine

Associated changes in source repos

Diff the source with this PR branch
darc vmr diff --name-only https://github.com/dotnet/dotnet:4707d71d0936130c7ef3fe7c9e5f5f755561c8a8..https://github.com/dotnet/sdk:darc-main-d609ca50-a993-45de-91e5-6aada7cde00a

@dotnet-maestro dotnet-maestro bot requested a review from a team as a code owner January 21, 2026 02:11
@DonnaChen888
Copy link
Contributor

@MiYanni could you please help me to take a look at this issue?
Known issue: dotnet/roslyn#82178.

Error:
C:\h\w\9F4B08F0\t\dotnetSdkTests\krinhew1.k1b\ILLink_can_us---0354D658\RequiresUnreferencedCodeAttribute.cs(38,22): warning CS8632: The annotation for nullable reference types should only be used in code within a '#nullable' annotations context. [C:\h\w\9F4B08F0\t\dotnetSdkTests\krinhew1.k1b\ILLink_can_us---0354D658\TrimmableNetstandardLibrary.csproj]
CSC : warning AD0001: Analyzer 'ILLink.RoslynAnalyzer.DynamicallyAccessedMembersAnalyzer' threw an exception of type 'System.MissingMethodException' with message 'Method not found: 'Microsoft.CodeAnalysis.IParameterSymbol Microsoft.CodeAnalysis.ITypeSymbol.get_ExtensionParameter()'.'. [C:\h\w\9F4B08F0\t\dotnetSdkTests\krinhew1.k1b\ILLink_can_us---0354D658\TrimmableNetstandardLibrary.csproj]

…IL3056: 'RequiresDynamicCodeAttribute' cannot be placed directly on static constructor 'C..cctor()'.
@dotnet-maestro
Copy link
Contributor Author

Important

While this PR was open, the source repository has received code changes from this repository (an opposite codeflow merged).
To avoid complex conflicts, the codeflow cannot continue until this PR is closed or merged.

You can continue with one of the following options:

  • Ignore this and merge this PR as usual without waiting for the new changes.
    Once merged, Maestro will create a new codeflow PR with the new changes.
  • Close this PR and wait for Maestro to open a new one with old and new changes included.
    You will lose any manual changes made in this PR.
    You can also manually trigger the new codeflow right away by running:
    darc trigger-subscriptions --id 94ba9a9b-a084-4c1e-bf44-d0c711c17773
    
  • Force a codeflow into this PR at your own risk if you want the new changes.
    User commits made to this PR might be reverted.
    darc trigger-subscriptions --id 94ba9a9b-a084-4c1e-bf44-d0c711c17773 --force
    

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

@dsplaisted
Copy link
Member

@dotnet/illink We're seeing test failures with the following:

CSC : warning AD0001: Analyzer 'ILLink.RoslynAnalyzer.DynamicallyAccessedMembersAnalyzer' threw an exception of type 'System.MissingMethodException' with message 'Method not found: 'Microsoft.CodeAnalysis.IParameterSymbol Microsoft.CodeAnalysis.ITypeSymbol.get_ExtensionParameter()'.'.

It looks like maybe there was an API change and we don't have the right versions synced up. Can someone help investigate this? Thanks.

@marcpopMSFT
Copy link
Member

@agocke who's a good person to look into the missing method exception dsplaisted mentions above.

@vitek-karas
Copy link
Member

That looks very much like dotnet/runtime#123503, @sbomer has been looking into that one.

@sbomer
Copy link
Member

sbomer commented Jan 28, 2026

This dependency update includes dotnet/dotnet#2822 which introduced the break - once the revert dotnet/dotnet#4404 flows this should be fixed.

@dsplaisted
Copy link
Member

@marcpopMSFT @mmitche What is needed for the changes from dotnet/dotnet#4404 to flow into this PR?

@DrewScoggins
Copy link
Member

Along those lines, is there any way we can update this PR to take the latest updates out of dotnet/dotnet? There is a revert that just made it in there that fixes an issue that causes the SDK to crash on all of our Windows AMD hardware in the performance lab. Looking at the update, we only have a commit from Jan 20, as far as the update to the runtime package is concerned.

@marcpopMSFT
Copy link
Member

I think it's configured to let us fix the PR before updating. I triggered the subscription with the --force option in hope that updates it.

@mmitche
Copy link
Member

mmitche commented Jan 30, 2026

Asusming we've had a successful build, darc trigger-subscriptions --id 94ba9a9b-a084-4c1e-bf44-d0c711c17773 --force will do it.

@marcpopMSFT
Copy link
Member

force trigger didn't work so going to reopen

@marcpopMSFT marcpopMSFT closed this Feb 6, 2026
@dotnet-maestro dotnet-maestro bot deleted the darc-main-d609ca50-a993-45de-91e5-6aada7cde00a branch February 6, 2026 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants