Feature #2425 tc_stat_rirw

[sethlinden]

Expected Differences

• Do these changes introduce new tools, command line arguments, or configuration file options? [Yes]
  
  If yes, please describe:
  

The -out_stat option can now be invoked for RIRW jobs. A new .stat output file will be created containing the 24 Common STAT Header columns along with either CTC and/or CTS header columns.

• Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
  
  If yes, please describe:
  

Pull Request Testing

• Describe testing already performed for these changes:
  

Tested using the following command line:

./tc_stat -lookin /d1/projects/MET/MET_regression/develop/NB20230503/MET-develop/test_output/tc_pairs/alal2010.tcst -job rirw -rirw_window 12 -rirw_thresh '<=-15' -out_line_type CTC,CTS -out_stat ./out.stat

Also called the same command line with -out_line_type CTC,CTS,MPR to verify that gives an Error message about not supporting MPR for the out_stat output file.

Added new test to TCStatConfig_ALAL2010:

"-job rirw -rirw_window 12 -rirw_thresh <=-15 -out_line_type CTC,CTS -out_stat ${MET_TEST_OUTPUT}/tc_stat/ALAL2010_rirw.stat"

Ran the unit test: unit_tc_stat.xml by hand

• Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
  

Run the updated unit test for: unit_tc_stat.xml
Check the new stat output file:

../MET/test_output/tc_stat/ALAL2010_rirw.stat

• Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

Yes, I updated the documentation in: docs/Users_Guide/tc-stat.rst, related to the RIRW job and being able to use the -out_stat option

• Do these changes include sufficient testing updates? [Yes]

Yes, updated the config file TCStatConfig_ALAL2010: used in unit_tc_stat.xml

• Will this PR result in changes to the test suite? [Yes or No]
  
  If yes, describe the new output and/or changes to the existing output:
  

Yes, it creates a new output file called:

../MET/test_output/tc_stat/ALAL2010_rirw.stat

• Please complete this pull request review by [Fill in date].
  

Pull Request Checklist

See the METplus Workflow for details.

• Review the source issue metadata (required labels, projects, and milestone).
• Complete the PR definition above.
• Ensure the PR title matches the feature or bugfix branch name.
• Define the PR metadata, as permissions allow.
  Select: Reviewer(s)
  Select: Organization level software support Project or Repository level development cycle Project
  Select: Milestone as the version that will include these changes
• After submitting the PR, select Development issue with the original issue number.
• After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
• Close the linked issue and delete your feature or bugfix branch from GitHub.

[JohnHalleyGotway]

I approve of these changes. @sethlinden, I would like to merge this PR myself. We have 3 PR's that will change the output. Once they're all reviewed, I'll merge them all and then update the truth dataset only once.

Note that I did make some edits on this branch.

• Removed specifics about the number of STAT header columns that might change in the future.
• Added StringArray::add_uniq(string) and used it in tc_stat_job.cc to reduce the number of LOC.
• Minor whitespace edits for consistent indents.

[sethlinden]

@JohnHalleyGotway thanks for the edits and small changes...they all look good and reasonable to me.