Bugfix #2402 develop sonarqube

[JohnHalleyGotway]

Expected Differences

• Do these changes introduce new tools, command line arguments, or configuration file options? [No]
  
  If yes, please describe:
  

• Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
  
  If yes, please describe:
  

Pull Request Testing

• Describe testing already performed for these changes:
  
  After porting over the changes, I just confirmed that the code still compiles. But the GHA testing workflow will also test that.

• Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
  

Make sure that the GHA testing workflow doesn't flag any diffs.
Briefly review the code changes.
I don't have a good way to prove that the findings are reduced by these change (as I did for MET#2447). Once these changers are merged into develop, we should see the existing MET NB blocker bugs reduce from 22 down to 10.

• Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
  None needed.

• Do these changes include sufficient testing updates? [Yes]
  None needed.

• Will this PR result in changes to the test suite? [No]
  
  If yes, describe the new output and/or changes to the existing output:
  

• Please complete this pull request review by [Mon 2/27/23].
  

Pull Request Checklist

See the METplus Workflow for details.

• Review the source issue metadata (required labels, projects, and milestone).
• Complete the PR definition above.
• Ensure the PR title matches the feature or bugfix branch name.
• Define the PR metadata, as permissions allow.
  Select: Reviewer(s)
  Select: Organization level software support Project or Repository level development cycle Project
  Select: Milestone as the version that will include these changes
• After submitting the PR, select Development issue with the original issue number.
• After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
• Close the linked issue and delete your feature or bugfix branch from GitHub.

[hsoh-u]

I approve of these changes.
I ran the unittest manually and compared the outputs with reference run at seneca. No differences for the output. I also ran cppchecker which runs on Windows OS and no finding by cppchecker.

[hsoh-u]

Unit test runtime difference (at seneca)
Note: first time is from Nightly build and the second time is my unit test run.
I did not check if it uses new code or not.
Case of longer execution time

TEST: pcp_combine_sum_GRIB1                    - pass -  19.163 sec
TEST: pcp_combine_sum_GRIB1                    - pass - 206.842 sec

Cases of faster execution time:

TEST: ascii2nc_WWSIS_clear_pvwatts_one_min   - pass -  60.852 sec
TEST: ascii2nc_WWSIS_clear_pvwatts_one_min   - pass -  14.048 sec

TEST: ascii2nc_WWSIS_pvwatts_one_min         - pass -  62.444 sec
TEST: ascii2nc_WWSIS_pvwatts_one_min         - pass -  14.252 sec