-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature #2168 tc_diag #2555
Feature #2168 tc_diag #2555
Conversation
…y itself as tc_pairs rather than tc_gen!
…monstrate the computation of consensus tracks. Note however that the TC-Pairs computed consensus do not match the output from NHC as closely as I'd expect.
… we want it to do yet.
…ig file. It was actually quietly supported. Just adding it for clarity.
… formatting, and get the tool compiling again.
…test runs but does NOT actually do much work. Had to use dynamically allocated arrays instead of a vector to avoid memory issues.
…ain yet. I'm still working on supporting multiple range/azimuth grids being used.
…quest the NetCDF range/azimuth output files since that's all that's supported in this version.
… files and replace JHG comments with TODO to list out future development tasks.
…w_analysis tool keeps working without any changes needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JohnHalleyGotway I have finished reviewing all of the code changes. They look good to me. I just left a few clarification questions and spotted a misspelling in one spot. This development represents a ton of work. Good job at getting this part of the finish line!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JohnHalleyGotway I have left some questions/comments for clarification. I have finished checking all of the code changes. This looks very good. It represents a ton of work, so congratulations on getting this first phase of the TCDiag tool across the finish line. !
Sorry for the duplicate messages. I thought perhaps I had not done my
review correctly, but now I just see that it adds it to the conversation.
|
Thanks for the review @jvigh. Proceeding with merging these changes. |
Co-authored-by: John Halley Gotway <johnhg@ucar.edu> Co-authored-by: Seth Linden <linden@seneca.rap.ucar.edu> Co-authored-by: jprestop <jpresto@ucar.edu> Co-authored-by: Daniel Adriaansen <dadriaan@ucar.edu> Co-authored-by: John and Cindy <halleygotway@Halleys-Mac-mini.local> Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu> Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com> Co-authored-by: hsoh-u <hsoh@ucar.edu> Co-authored-by: MET Tools Test Account <met_test@seneca.rap.ucar.edu> Co-authored-by: Seth Linden <linden@ucar.edu> Co-authored-by: lisagoodrich <33230218+lisagoodrich@users.noreply.github.com> Co-authored-by: davidalbo <dave@ucar.edu> Co-authored-by: Lisa Goodrich <lisag@ucar.edu> Co-authored-by: metplus-bot <97135045+metplus-bot@users.noreply.github.com> Co-authored-by: j-opatz <59586397+j-opatz@users.noreply.github.com> Fix Python environment issue (#2407) fix definitions of G172 and G220 based on comments in NOAA-EMC/NCEPLIBS-w3emc#157. (#2406) fix #2380 develop override (#2382) fix #2408 develop empty config (#2410) fix #2390 develop compile zlib (#2404) fix #2412 develop climo (#2422) fix #2437 develop convert (#2439) fix for develop, for #2437, forgot one reference to the search_parent for a dictionary lookup. fix #2452 develop airnow (#2454) fix #2449 develop pdf (#2464) fix #2402 develop sonarqube (#2468) fix #2426 develop buoy (#2475) fix 2518 dtypes appf docs (#2519) fix 2531 compilation errors (#2533) fix #2531 compilation_errors_configure (#2535)
* Update develop-ref after #2555 and #2561 (#2568) Co-authored-by: John Halley Gotway <johnhg@ucar.edu> Co-authored-by: Seth Linden <linden@seneca.rap.ucar.edu> Co-authored-by: jprestop <jpresto@ucar.edu> Co-authored-by: Daniel Adriaansen <dadriaan@ucar.edu> Co-authored-by: John and Cindy <halleygotway@Halleys-Mac-mini.local> Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu> Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com> Co-authored-by: hsoh-u <hsoh@ucar.edu> Co-authored-by: MET Tools Test Account <met_test@seneca.rap.ucar.edu> Co-authored-by: Seth Linden <linden@ucar.edu> Co-authored-by: lisagoodrich <33230218+lisagoodrich@users.noreply.github.com> Co-authored-by: davidalbo <dave@ucar.edu> Co-authored-by: Lisa Goodrich <lisag@ucar.edu> Co-authored-by: metplus-bot <97135045+metplus-bot@users.noreply.github.com> Co-authored-by: j-opatz <59586397+j-opatz@users.noreply.github.com> Fix Python environment issue (#2407) fix definitions of G172 and G220 based on comments in NOAA-EMC/NCEPLIBS-w3emc#157. (#2406) fix #2380 develop override (#2382) fix #2408 develop empty config (#2410) fix #2390 develop compile zlib (#2404) fix #2412 develop climo (#2422) fix #2437 develop convert (#2439) fix for develop, for #2437, forgot one reference to the search_parent for a dictionary lookup. fix #2452 develop airnow (#2454) fix #2449 develop pdf (#2464) fix #2402 develop sonarqube (#2468) fix #2426 develop buoy (#2475) fix 2518 dtypes appf docs (#2519) fix 2531 compilation errors (#2533) fix #2531 compilation_errors_configure (#2535) * Per #2582, update unit_plot_tc.xml to use the -save_data option. * modified the config for mode regarding multivar_intensity_flag * #2633 Set the default seeps_p1_thresh to >=0.1&&<=0.85 * #2633 Added default setting of seeps_p1_thresh * Per #2633, small tweaks to the config file comments and documentation --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: metplus-bot <97135045+metplus-bot@users.noreply.github.com> Co-authored-by: John Halley Gotway <johnhg@ucar.edu> Co-authored-by: David Albo <dave@ucar.edu> Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu>
This introduces the first version of the TC-Diag tool. This initial version is limited in functionality and only actually writes gridded NetCDF output in cylindrical coordinates. It does NOT actually compute TC diagnostics yet, but will do so in MET version 12.0.0.
Expected Differences
Do these changes introduce new tools, command line arguments, or configuration file options? [Yes]
If yes, please describe:
Adds new TC-Diag tool.
Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [Yes]
If yes, please describe:
Adds new NetCDF output from TC-Diag in cylindrical coordinates. It is pretty similar to the output from TC-RMW.
Pull Request Testing
Tested extensively during development.
Review code changes.
Review doc updates - although the actual doc contents will be updated by #2558.
Inspect the new output from the new unit_tc_diag.xml test.
Run on the command line and note the warning message about the "beta status".
While this does introduce a new TC-Diag chapter, I will review/revise it with #2558.
Yes, for now. We will want to add new tests and/or modify the existing one after the TC-Diag tool is more complete.
If yes, describe the new output and/or changes to the existing output:
Adds new output from
unit_tc_diag.xml
.Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes