Bugfix #2426 develop buoy

[davidalbo]

Expected Differences

• Do these changes introduce new tools, command line arguments, or configuration file options? [Yes]
  
  If yes, please describe:
  
  A new script: scripts/utility/build_ndbc_stations_from_web.py

• Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [yes]
  
  If yes, please describe:
  I changed the ndbc_stations.xml format to only include station/lat/lon/elev as these are the only things we are using.

Pull Request Testing

• Describe testing already performed for these changes: I replaced the ndbc_stations.xml file with the newer one generated by running the script, then ran the ascii2nc unit test that reads that file, setting an environment variable MET_NDBC_STATIONS to refer to my newer file, and the unit test passed.
  

• Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions: Try running the script with options (-h to see options, with no options it runs the default settings).

• 
  

• Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Hopefully] The documentation changes may or may not be where they should be and may or may not look good as is.

• Do these changes include sufficient testing updates? [Yes]

• Will this PR result in changes to the test suite? [No]
  
  If yes, describe the new output and/or changes to the existing output:
  

• Please complete this pull request review by [Feb 28 2023].
  

Pull Request Checklist

See the METplus Workflow for details.

• [x ] Review the source issue metadata (required labels, projects, and milestone).
• [ x] Complete the PR definition above.
• [x ] Ensure the PR title matches the feature or bugfix branch name.
• [ x] Define the PR metadata, as permissions allow.
  Select: Reviewer(s)
  Select: Organization level software support Project or Repository level development cycle Project
  Select: Milestone as the version that will include these changes
• After submitting the PR, select Development issue with the original issue number.
• After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
• Close the linked issue and delete your feature or bugfix branch from GitHub.

[JohnHalleyGotway]

As we discussed via Slack, if the elevation is missing, please just omit it from the XML output file. That'd be most consistent with the contents of the active stations XML file.

I reviewed the following:

1. I see that the number of stations in ndbc_stations.xml has increased from 1364 to 2613. Whereas the previous version included some metadata that went unused by MET (name, owner, type, met, currents, waterquality, dart, pgm), the updated version only includes the items that are actually needed (station id, lat, lon, elev).

2. The previous version only had elevation specified for 1053 of the 1364 while the new one specifies it for all 2613 locations. Although, if not specified, it's assigned a value of "-99.9":

<station id="yabp4" lat="18.055" lon="-65.833" elev="-99.9"/>

Recommend omitting "elev" if it's not specified.

3. I ran the build_ndbc_stations_from_web.py script and confirms that it runs without error.

[JohnHalleyGotway]

FYI, I updated the metadata for this PR to indicate that these changes are going into the develop branch for "Milestone = MET 11.1.0" and added it to the "Project = MET-11.1.0 Development" with "Cycle = beta1".

[JohnHalleyGotway]

I approve of these changes.

Thanks @davidalbo, I reran the python script and confirmed that it produced the expected change. I'll go ahead and merge this PR myself so that I can include it in the beta1 release now.