Feature #1693 equal_area #2567
Merged
Feature #1693 equal_area #2567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented the xy_to_latlon member function of the LaeaGrid class
…. The only real change here is defining LaeaGrid::serialize().
… as currently implemented. Since they rely on the vx_geodesy library, I also updated all the Makefile.am files by adding -lvx_geodesy immediately after each -lvx_grid entry.
…d in main_v10.0 and develop. Setting grid = name does not work when MET_PYTHON_EXE is set. The read_tmp_dataplane.py needs to be tweaked to support this usage.
…_area Manually merged sereval conflicts but haven't tested whether or not the result actually compiles.
…a. Note that it doesn't actually work yet and we need to add the input data for it.
…. Renamed existing LaeaData struct as LaeaCornerData. This compiles but I still need to parse data from GRIB2, CF-Compliant NetCDF files, MET NetCDF files, and grid strings.
…ize a grid using LAEAGrib2Data but just can't get the survive to the output step. The lg pointer is set initially but it gets reset to la.
…ted PostScript output file name so that the test will pass. Also update the config.tab.cc and color_parser_yacc.cc with the current NULLPTR contents that are created on seneca. Hopefully that'll solve the EmptyConfigFile GHA failure.
…ch vx_grid now depends.
…t this support should be restored prior to the MET-11.1.0 release.
20 tasks
|
Approving this PR and proceeding with the merge. The GHA run flagged only the newly added plot_data_plane output file. |
JohnHalleyGotway
pushed a commit
that referenced
this pull request
Jun 19, 2023
Co-authored-by: John Halley Gotway <johnhg@ucar.edu> Co-authored-by: jprestop <jpresto@ucar.edu> Co-authored-by: Seth Linden <linden@seneca.rap.ucar.edu> Co-authored-by: Daniel Adriaansen <dadriaan@ucar.edu> Co-authored-by: John and Cindy <halleygotway@Halleys-Mac-mini.local> Co-authored-by: rgbullock <bullock@ucar.edu> Co-authored-by: Randy Bullock <bullock@seneca.rap.ucar.edu> Co-authored-by: Dave Albo <dave@seneca.rap.ucar.edu> Co-authored-by: davidalbo <dave@ucar.edu> Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com> Co-authored-by: Lisa Goodrich <lisag@ucar.edu> Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu> Co-authored-by: hsoh-u <hsoh@ucar.edu> Co-authored-by: lisagoodrich <33230218+lisagoodrich@users.noreply.github.com> Co-authored-by: Seth Linden <linden@ucar.edu> Co-authored-by: metplus-bot <97135045+metplus-bot@users.noreply.github.com> Co-authored-by: j-opatz <59586397+j-opatz@users.noreply.github.com> fix #2449 develop pdf (#2464) fix #2402 develop sonarqube (#2468) fix #2426 develop buoy (#2475) fix 2518 dtypes appf docs (#2519) fix 2531 compilation errors (#2533) fix #2531 compilation_errors_configure (#2535) fix #2514 develop clang (#2563) fix #2575 develop python_convert (#2576)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected Differences
These are changes from @rgbullock to support reading LAEA grids from GRIB2 files. Note that these changes drop support for reading LAEA grids from CF-compliant NetCDF files. However, @rgbullock will restore that support via #2565.
Note the vast majority of the modified files are just Makefiles since the vx_grid library now depends on vx_geodesy for LAEA grids.
Do these changes introduce new tools, command line arguments, or configuration file options? [No]
If yes, please describe:
Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
If yes, please describe:
Pull Request Testing
Describe testing already performed for these changes:
Manually tested plot_data_plane with LAEA GRIB2 data.
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Review the code changes. Ensure all the GHA tests run, and note the diffs described below.
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]
No doc updates are included.
Do these changes include sufficient testing updates? [Yes]
Adds new test of GRIB2 LAEA file.
Will this PR result in changes to the test suite? [Yes]
If yes, describe the new output and/or changes to the existing output:
Adds new plot_data_plane output for GRIB2 LAEA data and (temporarily) removes a plot_data_plane output file for CF-compliant NetCDF LAEA data.
Please complete this pull request review by [Monday 6/12/23].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes