Bugfix #2306 ascii2nc airnow hourly

[davidalbo]

Expected Differences

• Do these changes introduce new tools, command line arguments, or configuration file options? No
  

• Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? No
  

Pull Request Testing

• Describe testing already performed for these changes: Ran the modified ascii2nc on an Hourly format ascii file and then ran the Rscript test on the output netCDF file, showing that the Infinity values were no longer there
  

• Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions: None I can think of
  

• Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? Yes

• Do these changes include sufficient testing updates? Yes

• Will this PR result in changes to the test suite? [Yes]
  
  The output of the unit test for Hourly format input data will change.
  

• Please complete this pull request review by ASAP.
  

Pull Request Checklist

See the METplus Workflow for details.

• Review the source issue metadata (required labels, projects, and milestone).
• Complete the PR definition above.
• Ensure the PR title matches the feature or bugfix branch name.
• Define the PR metadata, as permissions allow.
  Select: Reviewer(s)
  Select: Organization level software support Project or Repository level development cycle Project
  Select: Milestone as the version that will include these changes
• After submitting the PR, select Development with the original issue number.
• After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
• Close the linked issue and delete your feature or bugfix branch from GitHub.

[JohnHalleyGotway]

I approve of these changes. I will proceed with merging this PR and then updating the develop-ref branch accordingly.

I apologize for the long delay in this PR review! I see that these are the only difference flagged in the GHA run:

COMPARING ascii2nc/airnow/HourlyData_20220312.nc
file1: /data/output/met_test_truth/ascii2nc/airnow/HourlyData_20220312.nc
file2: /data/output/met_test_output/ascii2nc/airnow/HourlyData_20220312.nc
ERROR: NetCDF headers differ:
6,7c6,7
<       nhdr = 3638 ;
<       nobs = 13737 ;
---
>       nhdr = 3391 ;
>       nobs = 13078 ;
9c9
<       nhdr_sid = 3638 ;
---
>       nhdr_sid = 3391 ;

To compare, I dumped both of them to ascii and inspected the diffs:

Rscript pntnc2ascii.R HourlyData_20220312_TRUTH.nc > HourlyData_20220312_TRUTH.txt
Rscript pntnc2ascii.R HourlyData_20220312_OUTPUT.nc > HourlyData_20220312_OUTPUT.txt

While Inf appears on 247 "TRUTH" lines, it appears 0 times in the updated "OUTPUT".
And more to the point, differences exist on almost ALL of the ~13,000+ lines. Lots and lots of clearly uninitialized values in "TRUTH" now have very reasonable values in the "OUTPUT". These changes fix the stated problem.