Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SwiftLint fixes part 3 #462

Merged
merged 35 commits into from
Aug 17, 2023
Merged

SwiftLint fixes part 3 #462

merged 35 commits into from
Aug 17, 2023

Commits on Aug 8, 2023

  1. Autofix many SwiftLint warnings.

    @samsymons
    samsymons committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    951f5ce View commit details
    Browse the repository at this point in the history

  2. Format parts of EmailManager.

    @samsymons
    samsymons committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    acdcceb View commit details
    Browse the repository at this point in the history

  3. Disable line length warnings in SecureVaultManager tests for now. 

    This file had a ton of warnings, and I’m not sure if we care as much about this type of warning for test files.
    @samsymons
    samsymons committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    cdd1326 View commit details
    Browse the repository at this point in the history

  4. Allow force try calls within BookmarksProviderTests.

    @samsymons
    samsymons committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    cef2877 View commit details
    Browse the repository at this point in the history

  5. Disable force_cast and force_try errors in test files. 

    It’s reasonable to see these used in test files, but not production code.
    @samsymons
    samsymons committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    fe5fcba View commit details
    Browse the repository at this point in the history

  6. Disable some line_length warnings.

    @samsymons
    samsymons committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    fdadbde View commit details
    Browse the repository at this point in the history

  7. Allow file_length in test files also.

    @samsymons
    samsymons committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    31e9e9b View commit details
    Browse the repository at this point in the history

  8. Fix some duplicate imports.

    @samsymons
    samsymons committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    0ce5d41 View commit details
    Browse the repository at this point in the history

  9. Fix a handful of line length warnings.

    @samsymons
    samsymons committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    fc6ff4f View commit details
    Browse the repository at this point in the history

  10. Fix blanket disable command warnings.

    @samsymons
    samsymons committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    e8ce385 View commit details
    Browse the repository at this point in the history

  11. Disable line_length in test files.

    @samsymons
    samsymons committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    48f770a View commit details
    Browse the repository at this point in the history

  12. Fix a few more test suite issues.

    @samsymons
    samsymons committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    e8a23a1 View commit details
    Browse the repository at this point in the history

  13. Continue to fix test suite lint warnings.

    @samsymons
    samsymons committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    7f15591 View commit details
    Browse the repository at this point in the history

  14. Disable some more lint types in test files. Type body length shouldn’… 

    …t be a concern here.
    @samsymons
    samsymons committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    0766812 View commit details
    Browse the repository at this point in the history

  15. Begin working on all remaining lint warnings.

    @samsymons
    samsymons committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    8996e24 View commit details
    Browse the repository at this point in the history

  16. Fix some force_try usage.

    @samsymons
    samsymons committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    f530be1 View commit details
    Browse the repository at this point in the history

  17. More SwiftLint fixes.

    @samsymons
    samsymons committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    521151a View commit details
    Browse the repository at this point in the history

  18. Make an actual functional change to resolve a warning.

    @samsymons
    samsymons committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    161a598 View commit details
    Browse the repository at this point in the history

  19. Fix some indentation.

    @samsymons
    samsymons committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    0c922ae View commit details
    Browse the repository at this point in the history

  20. Add a couple blanket statements where the violations aren’t worse to … 

    …fix than they are to keep.
    @samsymons
    samsymons committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    1945cf3 View commit details
    Browse the repository at this point in the history

  21. Fixing more failures.

    @samsymons
    samsymons committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    83f2726 View commit details
    Browse the repository at this point in the history

  22. More fixes again. I can’t keep coming up with original commit message… 

    …s, you know.
    @samsymons
    samsymons committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    5ff9eaf View commit details
    Browse the repository at this point in the history

  23. Working through more lint failures.

    @samsymons
    samsymons committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    c100535 View commit details
    Browse the repository at this point in the history

  24. In the home stretch now.

    @samsymons
    samsymons committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    1f90c08 View commit details
    Browse the repository at this point in the history

  25. Fairly large batch of changes here.

    @samsymons
    samsymons committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    e429f0f View commit details
    Browse the repository at this point in the history

  26. More warnings fixed.

    @samsymons
    samsymons committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    17a813b View commit details
    Browse the repository at this point in the history

  27. Final lint changes.

    @samsymons
    samsymons committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    8a281f2 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2023

  1. Merge branch 'main' into sam/swiftlint-fixes-part-3 

    # By Sam Symons (3) and others
# Via GitHub
* main:
  Moved iOS Extension to BSK (#458)
  Bump Tests/BrowserServicesKitTests/Resources/privacy-reference-tests (#431)
  feat: duck player v2 (#451)
  Update NetP endpoint (#456)
  BSK SwiftLint fixes part 2: Disable some test suite warnings (#453)
  BSK SwiftLint fixes part 1: Autofix many SwiftLint warnings (#452)
  Add support for syncing Credentials (#425)
  Update autofill to 8.1.2 (#457)
  NetP - Create observers to extract from StatusReporter (#445)

# Conflicts:
#	Sources/BookmarksTestsUtils/BookmarkTree.swift
#	Sources/BrowserServicesKit/Autofill/AutofillUserScript+SecureVault.swift
#	Sources/BrowserServicesKit/SecureVault/AutofillSecureVault.swift
#	Sources/BrowserServicesKit/SecureVault/SecureVaultManager.swift
#	Sources/BrowserServicesKit/SecureVault/SecureVaultModels.swift
#	Sources/BrowserServicesKit/Suggestions/Suggestion.swift
#	Sources/SyncDataProviders/Bookmarks/BookmarksProvider.swift
#	Tests/.swiftlint.yml
#	Tests/BrowserServicesKitTests/SecureVault/MockAutofillDatabaseProvider.swift
#	Tests/BrowserServicesKitTests/SecureVault/VaultFactoryTests.swift
#	Tests/NavigationTests/ClosureNavigationResponderTests.swift
#	Tests/NavigationTests/Helpers/NavigationTestHelpers.swift
#	Tests/NavigationTests/NavigationAuthChallengeTests.swift
#	Tests/SecureStorageTests/TestMocks.swift
    @samsymons
    samsymons committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    4dab2fc View commit details
    Browse the repository at this point in the history

  2. Resolve new lint warnings.

    @samsymons
    samsymons committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    8f95abc View commit details
    Browse the repository at this point in the history

  3. Undo a change that isn’t needed, and add the scripts directory to the… 

    … exclusion list.
    @samsymons
    samsymons committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    ada2b84 View commit details
    Browse the repository at this point in the history

  4. Remove an unnecessary disable/enable block.

    @samsymons
    samsymons committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    1218e11 View commit details
    Browse the repository at this point in the history

  5. Fix some newlines in SecureStorageError.

    @samsymons
    samsymons committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    93f9de9 View commit details
    Browse the repository at this point in the history

  6. Xcode really doesn’t want to trim whitespace huh?

    @samsymons
    samsymons committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    3bd6db2 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2023

  1. Small tuples only, please

    @samsymons
    samsymons committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    59510b6 View commit details
    Browse the repository at this point in the history

  2. Small tuples only: unit tests edition

    @samsymons
    samsymons committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    aebf349 View commit details
    Browse the repository at this point in the history