Skip to content
This repository was archived by the owner on Feb 24, 2025. It is now read-only.

Conversation

@samsymons
Copy link
Contributor

Please review the release process for BrowserServicesKit here.

Required:

Task/Issue URL: https://app.asana.com/0/0/1205371338744155/f
iOS PR: N/A
macOS PR: N/A
What kind of version bump will this require?: None, this is a workflow change

CC: @ayoy

Description:

This PR enables nightly CodeQL scans. The iOS equivalent was done here: duckduckgo/iOS#1958

Steps to test this PR:

  1. Check that this PR has a CodeQL alert visible
  2. Remove the code that triggers this alert (see commit history for that)
  3. Check that the alert goes away

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16
  • macOS 10.15
  • macOS 11
  • macOS 12

Internal references:

Software Engineering Expectations
Technical Design Template

@samsymons samsymons requested review from a team and bwaresiak and removed request for a team August 29, 2023 04:00
@duckduckgo duckduckgo deleted a comment from NelsonSolis90 Aug 29, 2023
@samsymons samsymons requested a review from ayoy August 29, 2023 14:59
Copy link
Contributor

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @samsymons!

… into sam/codeql

* 'sam/codeql' of github.com:duckduckgo/BrowserServicesKit:
  Revert "Add forced CodeQL alerts."
@samsymons samsymons merged commit ee1cd47 into main Aug 29, 2023
@samsymons samsymons deleted the sam/codeql branch August 29, 2023 21:19
samsymons added a commit that referenced this pull request Aug 30, 2023
* main:
  Fix auth token issues (#484)
  Enable nightly CodeQL scans (#481)
  add assertions to AdClickAttributionLogic, improve debug checks (#476)
  Set unencrypted password for deduplicated Credentials object (#480)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants