This repository was archived by the owner on Feb 24, 2025. It is now read-only.
Fix auth token issues #484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegoreymendez
added a commit
to duckduckgo/macos-browser
that referenced
this pull request
Aug 30, 2023
Task/Issue URL: https://app.asana.com/0/0/1205381920971736/f BSK PR: duckduckgo/BrowserServicesKit#484 iOS PR: duckduckgo/iOS#1966 ## Description Fixes some auth token regressions. See the parent task for background info. The issue is that our system extension still needs per-build service names, while our App and agent don't (and are better off without them).
diegoreymendez
added a commit
to duckduckgo/iOS
that referenced
this pull request
Aug 30, 2023
Task/Issue URL: https://app.asana.com/0/0/1205381920971738/f BSK PR: duckduckgo/BrowserServicesKit#484 macOS PR: duckduckgo/macos-browser#1563 ## Description Integrates some recent changes in BSK.
samsymons
added a commit
that referenced
this pull request
Aug 30, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1205381920971737/f
macOS PR: duckduckgo/macos-browser#1563
iOS PR: duckduckgo/iOS#1966
Description
Fixes some auth token regressions. See the parent task for background info.
The issue is that our system extension still needs per-build service names, while our App and agent don't (and are better off without them).
Steps to test this PR
Use the macOS PR to test this.
Internal references:
Software Engineering Expectations
Technical Design Template