This repository was archived by the owner on Feb 24, 2025. It is now read-only.
Fix AdClickAttributionLogic leaking NavigationResponse completionBlock #476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ks on Task cancellation
bwaresiak
reviewed
Aug 24, 2023
Sources/BrowserServicesKit/ContentBlocking/AdClickAttribution/AdClickAttributionLogic.swift
Outdated
Show resolved
Hide resolved
bwaresiak
reviewed
Aug 24, 2023
Sources/BrowserServicesKit/ContentBlocking/AdClickAttribution/AdClickAttributionLogic.swift
Outdated
Show resolved
Hide resolved
bwaresiak
reviewed
Aug 24, 2023
Sources/BrowserServicesKit/ContentBlocking/AdClickAttribution/AdClickAttributionLogic.swift
Outdated
Show resolved
Hide resolved
bwaresiak
reviewed
Aug 24, 2023
Sources/BrowserServicesKit/ContentBlocking/AdClickAttribution/AdClickAttributionLogic.swift
Outdated
Show resolved
Hide resolved
bwaresiak
reviewed
Aug 28, 2023
| /// continues until first non-nil Navigation Responder decision and returned to the `completion` callback | ||
| func makeAsyncDecision<T>(boundToLifetimeOf webView: WKWebView, | ||
| func makeAsyncDecision<T>(for actionDebugInfo: some CustomDebugStringConvertible, | ||
| boundToLifetimeOf webView: WKWebView, |
Collaborator
There was a problem hiding this comment.
Didn't we agree to disable this kind of warning?
Collaborator
Author
There was a problem hiding this comment.
As I remember we agreed to make it less intrusive (to stop debugger and not cause assertion) and provide more info. This won't affect CI runners as there's no debugger but may help detecting some issues
mallexxx
added a commit
to duckduckgo/macos-browser
that referenced
this pull request
Aug 29, 2023
samsymons
added a commit
that referenced
this pull request
Aug 30, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL: https://app.asana.com/0/1199230911884351/1205322007351871/f
iOS PR: not needed
macOS PR: duckduckgo/macos-browser#1538
What kind of version bump will this require?: Patch
Description:
onProvisionalNavigationleaking completionBlocks on Navigation Task cancellationDistributedNavigationDelegate.checkLongDecisionMakingSteps to test this PR:
checkLongDecisionMakingassertion