Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ntp: customizer drawer screens #1303

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Conversation

shakyShane
Copy link
Contributor

@shakyShane shakyShane commented Dec 3, 2024

Asana Task/Github Issue:

Description

  • added a baseline implementation of every UI interaction (minus animations and polish)
  • designed for early merge, so the changes SHOULD NOT impact the existing NTP (the one without the drawer enabled)

Testing Steps

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

Copy link

github-actions bot commented Dec 3, 2024

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

netlify bot commented Dec 3, 2024

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 6c6784c
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/6761ea8531e51a00085badd0
😎 Deploy Preview https://deploy-preview-1303--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shakyShane
Copy link
Contributor Author

shakyShane commented Dec 3, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

github-actions bot commented Dec 3, 2024

[Beta] Generated file diff

Time updated: Tue, 17 Dec 2024 21:19:00 GMT

Integration
    - integration/pages/new-tab/dist/index.css
  • integration/pages/new-tab/dist/index.js

File has changed

Windows
    - windows/pages/new-tab/dist/index.css
  • windows/pages/new-tab/dist/index.js

File has changed

Apple
    - dist/pages/new-tab/dist/index.css
  • dist/pages/new-tab/dist/index.js

File has changed

@shakyShane shakyShane force-pushed the shane/ntp-customizer-presets branch from 74b67a3 to fe3a5fd Compare December 4, 2024 16:54
*/
export const values = {
colors: {
color01: { hex: '#000000', colorScheme: 'dark' },
Copy link
Contributor

@vkraucunas vkraucunas Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we maybe give the PredefinedColors / PredefinedGradients a name or description for a11y?
caveat: this would be a value we’d need to get translations for.

@shakyShane shakyShane force-pushed the shane/ntp-customizer-presets branch 3 times, most recently from 5e60ef1 to 22a120c Compare December 15, 2024 21:40
@shakyShane shakyShane changed the base branch from main to shane/special-workflow December 15, 2024 21:40
@shakyShane shakyShane force-pushed the shane/ntp-customizer-presets branch 3 times, most recently from 6937d18 to c6a49d8 Compare December 16, 2024 12:17
@shakyShane shakyShane changed the base branch from shane/special-workflow to shane/ntp-customizer-data December 16, 2024 12:17
@shakyShane shakyShane mentioned this pull request Dec 16, 2024
9 tasks
@shakyShane shakyShane force-pushed the shane/ntp-customizer-data branch from bec9d55 to ddd78b8 Compare December 16, 2024 13:09
@shakyShane shakyShane force-pushed the shane/ntp-customizer-presets branch from c6a49d8 to ab8ee9e Compare December 16, 2024 13:10
@shakyShane shakyShane force-pushed the shane/ntp-customizer-data branch from ddd78b8 to 206cb4d Compare December 16, 2024 13:50
@shakyShane shakyShane force-pushed the shane/ntp-customizer-presets branch from ab8ee9e to e884049 Compare December 16, 2024 13:50
@shakyShane shakyShane changed the base branch from shane/ntp-customizer-data to shane/ntp-customizer-globals December 16, 2024 13:50
@shakyShane shakyShane mentioned this pull request Dec 16, 2024
11 tasks
@shakyShane shakyShane force-pushed the shane/ntp-customizer-presets branch from e884049 to 17a70be Compare December 16, 2024 14:05
@shakyShane shakyShane force-pushed the shane/ntp-customizer-globals branch from 94d7b37 to e185ed6 Compare December 16, 2024 14:06
@shakyShane shakyShane force-pushed the shane/ntp-customizer-presets branch from 17a70be to 6e35d03 Compare December 16, 2024 14:06
@shakyShane shakyShane force-pushed the shane/ntp-customizer-globals branch from e185ed6 to 0e41d63 Compare December 16, 2024 16:59
@shakyShane shakyShane force-pushed the shane/ntp-customizer-presets branch from 04dab36 to 1a402db Compare December 16, 2024 16:59
@shakyShane shakyShane force-pushed the shane/ntp-customizer-globals branch from 0e41d63 to d5ab06c Compare December 16, 2024 22:00
@shakyShane shakyShane force-pushed the shane/ntp-customizer-presets branch from 1a402db to 14522fa Compare December 16, 2024 22:00
Base automatically changed from shane/ntp-customizer-globals to main December 17, 2024 07:47
@shakyShane shakyShane force-pushed the shane/ntp-customizer-presets branch 2 times, most recently from ed2bfc3 to 77b528b Compare December 17, 2024 10:57
@shakyShane shakyShane changed the base branch from main to 12-17-ntp_fixing_components_iew December 17, 2024 10:57
@shakyShane shakyShane mentioned this pull request Dec 17, 2024
9 tasks
Base automatically changed from 12-17-ntp_fixing_components_iew to main December 17, 2024 11:28
@shakyShane shakyShane force-pushed the shane/ntp-customizer-presets branch from 77b528b to a70b446 Compare December 17, 2024 14:15
@shakyShane shakyShane mentioned this pull request Dec 17, 2024
13 tasks
@shakyShane shakyShane marked this pull request as ready for review December 17, 2024 15:04
@shakyShane shakyShane requested review from mgurgel and a team as code owners December 17, 2024 15:04
@shakyShane shakyShane changed the title ntp: customizer presets ntp: customizer drawer screens Dec 17, 2024
@vkraucunas
Copy link
Contributor

vkraucunas commented Dec 17, 2024

Update: Made into a subtask.
So the shared Button in RMF and PIR banner doesn’t seem to be respecting the NTP page theme change. I don’t see this as a blocking bug for merging this work, but should be swept up before delivery.
Screenshot 2024-12-17 at 11 32 58 AM

@shakyShane shakyShane force-pushed the shane/ntp-customizer-presets branch from 634d60b to 6c6784c Compare December 17, 2024 21:17
@shakyShane shakyShane merged commit 2012858 into main Dec 18, 2024
13 checks passed
@shakyShane shakyShane deleted the shane/ntp-customizer-presets branch December 18, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants