special-pages: integrated watch mode #1317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
✅ Deploy Preview for content-scope-scripts ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Temporary Branch UpdateThe temporary branch has been updated with the latest changes. Below are the details:
Please use the above install command to update to the latest version. |
[Beta] Generated file diffTime updated: Mon, 16 Dec 2024 13:10:45 GMT AndroidFile has changed Removed Files
❌ File only exists in old changeset Integration
File has changed Windows
File has changed Apple
File has changed New Files
❌ File only exists in new changeset |
10 tasks
mgurgel
reviewed
Dec 16, 2024
| import { init } from '../../app/index.js'; | ||
| import { Environment } from '../../../shared/environment.js'; | ||
| import { createSpecialPageMessaging } from '../../../shared/create-special-page-messaging.js'; | ||
| import { init } from '../app/index.js'; |
There was a problem hiding this comment.
Suggested change
| import { init } from '../app/index.js'; | |
| import { init } from '../app/index.js'; | |
| import '../../../shared/live-reload.js'; |
mgurgel
reviewed
Dec 16, 2024
| import { mockTransport } from './mock-transport.js'; | ||
| import { init } from '../../app/index.js'; | ||
| import { init } from '../app/index.js'; |
There was a problem hiding this comment.
Suggested change
| import { init } from '../app/index.js'; | |
| import { init } from '../app/index.js'; | |
| import '../../../shared/live-reload.js'; |
mgurgel
previously approved these changes
Dec 16, 2024
9 tasks
shakyShane
force-pushed
the
shane/special-workflow
branch
from
18d5123 to
760c5e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana Task/Github Issue:
Description
** Before **
When running
npm run watch- changes to ANY file would cause every special-page to be rebuilt from scratch.This worked ok with few pages and very little assets. But now as the projects grow in size and complexity, we need to consider them as isolated applications in terms of development.
** After **
When running
npm run watch — —page=onboarding, only files in the onboarding project are watched 💪🏻.Testing Steps
special-pages, runnpm run watch — —page=onboarding(or any other page)Checklist
Please tick all that apply: