Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ntp: customizer data/messages #1328

Merged
merged 1 commit into from
Dec 16, 2024
Merged

ntp: customizer data/messages #1328

merged 1 commit into from
Dec 16, 2024

Conversation

shakyShane
Copy link
Contributor

@shakyShane shakyShane commented Dec 16, 2024

Asana Task/Github Issue: https://app.asana.com/0/1201141132935289/1208987638565305/f

Description

  • Added messages/types/images from the customizer branch

Testing Steps

  • no functional change, just making the next PRs smaller

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@shakyShane shakyShane mentioned this pull request Dec 16, 2024
10 tasks
@shakyShane
Copy link
Contributor Author

shakyShane commented Dec 16, 2024

Copy link

github-actions bot commented Dec 16, 2024

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@shakyShane shakyShane marked this pull request as ready for review December 16, 2024 12:17
@shakyShane shakyShane requested review from mgurgel and a team as code owners December 16, 2024 12:17
Copy link

github-actions bot commented Dec 16, 2024

[Beta] Generated file diff

Time updated: Mon, 16 Dec 2024 13:51:31 GMT

New Files
    - integration/pages/new-tab/backgrounds/bg-01-thumb.jpg
  • integration/pages/new-tab/backgrounds/bg-01.jpg
  • integration/pages/new-tab/backgrounds/bg-02-thumb.jpg
  • integration/pages/new-tab/backgrounds/bg-02.jpg
  • integration/pages/new-tab/backgrounds/bg-03-thumb.jpg
  • integration/pages/new-tab/backgrounds/bg-03.jpg
  • integration/pages/new-tab/gradients/gradient01.svg
  • integration/pages/new-tab/gradients/gradient02.svg
  • integration/pages/new-tab/gradients/gradient03.svg
  • integration/pages/new-tab/gradients/gradient04.svg
  • integration/pages/new-tab/gradients/gradient05.svg
  • integration/pages/new-tab/gradients/gradient06.svg
  • integration/pages/new-tab/gradients/gradient07.svg
  • integration/pages/new-tab/gradients/gradient08.svg
  • integration/pages/new-tab/gradients/grain.png
  • windows/pages/new-tab/backgrounds/bg-01-thumb.jpg
  • windows/pages/new-tab/backgrounds/bg-01.jpg
  • windows/pages/new-tab/backgrounds/bg-02-thumb.jpg
  • windows/pages/new-tab/backgrounds/bg-02.jpg
  • windows/pages/new-tab/backgrounds/bg-03-thumb.jpg
  • windows/pages/new-tab/backgrounds/bg-03.jpg
  • windows/pages/new-tab/gradients/gradient01.svg
  • windows/pages/new-tab/gradients/gradient02.svg
  • windows/pages/new-tab/gradients/gradient03.svg
  • windows/pages/new-tab/gradients/gradient04.svg
  • windows/pages/new-tab/gradients/gradient05.svg
  • windows/pages/new-tab/gradients/gradient06.svg
  • windows/pages/new-tab/gradients/gradient07.svg
  • windows/pages/new-tab/gradients/gradient08.svg
  • windows/pages/new-tab/gradients/grain.png
  • dist/pages/new-tab/backgrounds/bg-01-thumb.jpg
  • dist/pages/new-tab/backgrounds/bg-01.jpg
  • dist/pages/new-tab/backgrounds/bg-02-thumb.jpg
  • dist/pages/new-tab/backgrounds/bg-02.jpg
  • dist/pages/new-tab/backgrounds/bg-03-thumb.jpg
  • dist/pages/new-tab/backgrounds/bg-03.jpg
  • dist/pages/new-tab/gradients/gradient01.svg
  • dist/pages/new-tab/gradients/gradient02.svg
  • dist/pages/new-tab/gradients/gradient03.svg
  • dist/pages/new-tab/gradients/gradient04.svg
  • dist/pages/new-tab/gradients/gradient05.svg
  • dist/pages/new-tab/gradients/gradient06.svg
  • dist/pages/new-tab/gradients/gradient07.svg
  • dist/pages/new-tab/gradients/gradient08.svg
  • dist/pages/new-tab/gradients/grain.png

❌ File only exists in new changeset

@shakyShane shakyShane force-pushed the shane/special-workflow branch from 18d5123 to 760c5e8 Compare December 16, 2024 13:09
@shakyShane shakyShane force-pushed the shane/ntp-customizer-data branch from bec9d55 to ddd78b8 Compare December 16, 2024 13:09
mgurgel
mgurgel previously approved these changes Dec 16, 2024
Copy link
Contributor

@mgurgel mgurgel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Base automatically changed from shane/special-workflow to main December 16, 2024 13:47
@shakyShane shakyShane dismissed mgurgel’s stale review December 16, 2024 13:47

The base branch was changed.

@shakyShane shakyShane force-pushed the shane/ntp-customizer-data branch from ddd78b8 to 206cb4d Compare December 16, 2024 13:50
@shakyShane shakyShane mentioned this pull request Dec 16, 2024
11 tasks
Copy link

netlify bot commented Dec 16, 2024

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 206cb4d
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/6760301ca197de0008c038b3
😎 Deploy Preview https://deploy-preview-1328--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shakyShane shakyShane merged commit 8a25d52 into main Dec 16, 2024
12 checks passed
@shakyShane shakyShane deleted the shane/ntp-customizer-data branch December 16, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants