Run password rules workflow on schedule #334
Merged
+29
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alistairjcbrown
force-pushed
the
abrown/update-password-rules-workflow
branch
3 times, most recently
from
188a42a
to
c0e7ece
Compare
alistairjcbrown
force-pushed
the
abrown/update-password-rules-workflow
branch
from
46bc6a0
to
49407d5
Compare
shakyShane
approved these changes
Jun 22, 2023
| echo "currentDate=$(date +'%Y-%m-%d')" >> "$GITHUB_OUTPUT" | ||
| - name: Create PR for updated rules | ||
| if: ${{ steps.changes.outputs.hasChanged == 'true' }} | ||
| uses: peter-evans/create-pull-request@88bf0de51c7487d91e1abbb4899332e602c58bbf |
There was a problem hiding this comment.
I was going to question the use of this - but then I realised it's used in the autofill automation already :)
There was a problem hiding this comment.
@shakyShane Yeah, just copy-pasted the one we're using for the release flow 😁 -- I assume it's the version that's been checked and that we're good to use.
This was referenced Jul 14, 2023
CDRussell
pushed a commit
to duckduckgo/Android
that referenced
this pull request
Jul 14, 2023
Task/Issue URL: https://app.asana.com/0/1205060095332912/1205060095332912 Autofill Release: https://github.com/duckduckgo/duckduckgo-autofill/releases/tag/8.0.0 ## Description Updates Autofill to version [8.0.0](https://github.com/duckduckgo/duckduckgo-autofill/releases/tag/8.0.0). ### Autofill 8.0.0 release notes ## What's Changed * Remove in-context eligible pixel by @alistairjcbrown in duckduckgo/duckduckgo-autofill#330 * Run password rules workflow on schedule by @alistairjcbrown in duckduckgo/duckduckgo-autofill#334 * Add build step after pulling password rules by @alistairjcbrown in duckduckgo/duckduckgo-autofill#338 * Update password rules (2023-06-23) by @daxmobile in duckduckgo/duckduckgo-autofill#341 * Update password rules (2023-06-27) by @daxmobile in duckduckgo/duckduckgo-autofill#345 * tests: attach JSON mocks as attachments by @shakyShane in duckduckgo/duckduckgo-autofill#348 * tests: decouple 'login helpers' from navigating to separate tests by @shakyShane in duckduckgo/duckduckgo-autofill#350 * Couple more fixes by @GioSensation in duckduckgo/duckduckgo-autofill#351 * fix: Typescript bug in tests + removed duplication within in-context tests by @shakyShane in duckduckgo/duckduckgo-autofill#352 * Testing updates by @shakyShane in duckduckgo/duckduckgo-autofill#356 * Update password rules (2023-07-12) by @daxmobile in duckduckgo/duckduckgo-autofill#357 * feat: email protection saving by @shakyShane in duckduckgo/duckduckgo-autofill#355 ## New Contributors * @daxmobile made their first contribution in duckduckgo/duckduckgo-autofill#341 **Full Changelog**: duckduckgo/duckduckgo-autofill@7.2.0...8.0.0 ## Steps to test This release has been tested during autofill development. For smoke test steps see [this task](https://app.asana.com/0/1198964220583541/1200583647142330/f). Co-authored-by: shakyShane <shakyShane@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer: @shakyShane
Asana: https://app.asana.com/0/1198964220583541/1204875111329300/f
Description
Move password rules generation to schedule and PR
Steps to test
Test run created PR -- #335