tests: decouple 'login helpers' from navigating to separate tests

[shakyShane]

Reviewer: @GioSensation @alistairjcbrown
Asana:

Description

• removes additional page wrappers, in favour of a strongly typed 'navigate(pageType)' call instead
• removed the string values from some test helpers - not using the constants object directly as types with keyof typeof constants.pages

** before **

export function loginPageWithPoorForm (page, opts) {
    const originalLoginPage = loginPage(page, opts)
    return {
        ...originalLoginPage,
        async navigate () {
            await page.goto(constants.pages['loginWithPoorForm'])
        }
    }
}

after

const login = loginPage(page, opts);
await login.navigate('loginWithPoorForm') // where 'loginWithPoorForm' must be a key in `constants.pages`

Steps to test

[shakyShane]

Current dependencies on/for this PR:

• main
  • PR tests: decouple 'login helpers' from navigating to separate tests #350 👈

This comment was auto-generated by Graphite.

[GioSensation]

Nice little improvement. Thanks!

[GioSensation]

Mhm, weird that these weren't in use. We probably removed the feature recently and removed the tests, but forgot to remove the helpers here. Anyway, we can put them back if needed.

[shakyShane]

yeah exactly my thoughts :)