Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: attach JSON mocks as attachments #348

Merged
merged 2 commits into from
Jul 10, 2023
Merged

Conversation

shakyShane
Copy link
Collaborator

@shakyShane shakyShane commented Jul 10, 2023

Reviewer: @GioSensation
Asana: https://app.asana.com/0/0/1204998354790815/f

Description

  • Moved some playwright config into the 'correct' place, this enables us to simplify the harness creation - and will help towards the goal of re-usable cross-platform tests (to remove some duplication)
  • Uses a single testContext now - this makes it easy to see what's different per platform and to share functionality, such as appending JSON mocks to the test output
  • No functional changes here to Autofill, just splitting up a bigger PR into easy-to-review chunks :)
Screenshot 2023-07-10 at 10 48 39 Screenshot 2023-07-10 at 10 53 03

Steps to test

@shakyShane
Copy link
Collaborator Author

shakyShane commented Jul 10, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

Copy link
Member

@GioSensation GioSensation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've given this a quick look and it seems fine. Thanks for doing this, I was looking forward to unifying those.

@shakyShane shakyShane merged commit 9fd4130 into main Jul 10, 2023
2 checks passed
CDRussell pushed a commit to duckduckgo/Android that referenced this pull request Jul 14, 2023
Task/Issue URL:
https://app.asana.com/0/1205060095332912/1205060095332912
Autofill Release:
https://github.com/duckduckgo/duckduckgo-autofill/releases/tag/8.0.0


## Description
Updates Autofill to version
[8.0.0](https://github.com/duckduckgo/duckduckgo-autofill/releases/tag/8.0.0).

### Autofill 8.0.0 release notes
## What's Changed
* Remove in-context eligible pixel by @alistairjcbrown in
duckduckgo/duckduckgo-autofill#330
* Run password rules workflow on schedule by @alistairjcbrown in
duckduckgo/duckduckgo-autofill#334
* Add build step after pulling password rules by @alistairjcbrown in
duckduckgo/duckduckgo-autofill#338
* Update password rules (2023-06-23) by @daxmobile in
duckduckgo/duckduckgo-autofill#341
* Update password rules (2023-06-27) by @daxmobile in
duckduckgo/duckduckgo-autofill#345
* tests: attach JSON mocks as attachments by @shakyShane in
duckduckgo/duckduckgo-autofill#348
* tests: decouple 'login helpers' from navigating to separate tests by
@shakyShane in
duckduckgo/duckduckgo-autofill#350
* Couple more fixes by @GioSensation in
duckduckgo/duckduckgo-autofill#351
* fix: Typescript bug in tests + removed duplication within in-context
tests by @shakyShane in
duckduckgo/duckduckgo-autofill#352
* Testing updates by @shakyShane in
duckduckgo/duckduckgo-autofill#356
* Update password rules (2023-07-12) by @daxmobile in
duckduckgo/duckduckgo-autofill#357
* feat: email protection saving by @shakyShane in
duckduckgo/duckduckgo-autofill#355

## New Contributors
* @daxmobile made their first contribution in
duckduckgo/duckduckgo-autofill#341

**Full Changelog**:
duckduckgo/duckduckgo-autofill@7.2.0...8.0.0

## Steps to test
This release has been tested during autofill development. For smoke test
steps see [this
task](https://app.asana.com/0/1198964220583541/1200583647142330/f).

Co-authored-by: shakyShane <shakyShane@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants