Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autofill: Fix footer sizing for multiline labels #2422

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

amddg44
Copy link
Contributor

@amddg44 amddg44 commented Jan 31, 2024

Task/Issue URL: https://app.asana.com/0/1201462886803403/1206371260426517/f
Tech Design URL:
CC:

Description:
This is a fix for the autofill tableview footer label not sizing correctly when there is more than one line of text

Steps to test this PR:

  1. In English, go the Passwords screen and confirm the footer label in the top section displays correctly
    image

  2. Change the phone language to french and go back to the Passwords screen and confirm the footer view correctly displays 2 lines of text
    image

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@amddg44 amddg44 requested review from a team and jotaemepereira and removed request for a team January 31, 2024 12:22
Copy link
Contributor

@jotaemepereira jotaemepereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍🏼

@amddg44 amddg44 merged commit e06582a into main Feb 5, 2024
10 checks passed
@amddg44 amddg44 deleted the anya/fix-footer-multiline-layout branch February 5, 2024 09:39
samsymons added a commit that referenced this pull request Feb 8, 2024
# By Mariusz Śpiewak (11) and others
# Via Bartek Waresiak (3) and others
* main: (52 commits)
  Release 7.108.0-3 (#2454)
  User Authentication (#2431)
  Fix BSK reference to tagged version (#2447)
  Set proper border color for widgets (#2446)
  Check subfeature state before reading rollout data (#2426)
  Remove the mock VPN invite code (#2442)
  Release 7.108.0-2 (#2445)
  Keep DuckDuckGo Settings after Fire Button (#2444)
  Release 7.108.0-1 (#2440)
  Release 7.107.1-1 (#2439)
  Updates internal user flag to reset state (#2438)
  Release 7.107.1-0 (#2437)
  Hide the debug menu when debug mode is not enabled (#2436)
  Autoconsent 9.7.2 (#2425)
  Release 7.108.0-0 (#2432)
  Autofill: Fix footer sizing for multiline labels (#2422)
  Add rollout for cookie popup management enabled by default (#2373)
  Update BSK with autofill 10.1.0 (#2414)
  Bump submodules/privacy-reference-tests from `a3acc21` to `6b7ad1e` (#2408)
  Add Autoconsent onByDefault subfeature (#2423)
  ...

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants