Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoconsent 9.7.2 #2425

Merged
merged 2 commits into from
Feb 5, 2024
Merged

Autoconsent 9.7.2 #2425

merged 2 commits into from
Feb 5, 2024

Conversation

muodov
Copy link
Member

@muodov muodov commented Feb 2, 2024

Task/Issue URL: https://app.asana.com/0/0/1206503360511054/f
Tech Design URL:
CC:

Description:
Updates autoconsent rules

Steps to test this PR:
Cookie pop-ups should be handled on these example sites:
https://www.dell.com/de-de
https://www.taxi.de/
https://www.briogeohair.com/
https://bahn.de
https://connect.botify.com/usa2023
https://www.matadorequipment.com/
https://www.theposh.com/table/226
https://mobalytics.gg/
https://www.dealnews.com
https://ec.europa.eu
https://xvideos.com
https://ecosia.org
https://verizon.com
https://reddit.com
https://xe.com
https://ourworldindata.org
https://www.svt.se/
https://productz.com
https://dndbeyond.com
https://jdsports.co.uk
https://www.wolframalpha.com
https://www.arbeitsagentur.de
https://developer.hashicorp.com/boundary/tutorials/oss-getting-started/oss-getting-started-install
https://setapp.com/
https://www.nytimes.com/puzzles/spelling-bee
https://careers.cloud.com/CloudCareers
https://www.ups.com/us/en/Home.page
https://www.nexaas.com/
https://www.boltive.com/
https://www.polygon.com/
https://www.chargebee.com/payment-gateways/
https://www.modular.com/
https://www.prucenter.com/events
https://hu-manity.co/
https://mediamanager.internetvideoarchive.com/
https://www.greenbuildingadvisor.com/question/adding-outside-air-vent-to-existing-hvac
https://www.briogeohair.com/
https://pabcogypsum.com/products/quietrock-es/
https://www.abconcerts.be/en/agenda/gabriel-rios/a105J0000071H51QAE
https://olli-machts.de/en/extension/cookie-manager
https://tinydots.pl/

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@muodov muodov requested review from a team, alessandroboron and federicocappelli and removed request for a team and alessandroboron February 2, 2024 14:56
Copy link
Contributor

@dus7 dus7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@muodov muodov merged commit 5bf79e8 into main Feb 5, 2024
10 checks passed
@muodov muodov deleted the autoconsent-9.7.0 branch February 5, 2024 15:34
samsymons added a commit that referenced this pull request Feb 8, 2024
# By Mariusz Śpiewak (11) and others
# Via Bartek Waresiak (3) and others
* main: (52 commits)
  Release 7.108.0-3 (#2454)
  User Authentication (#2431)
  Fix BSK reference to tagged version (#2447)
  Set proper border color for widgets (#2446)
  Check subfeature state before reading rollout data (#2426)
  Remove the mock VPN invite code (#2442)
  Release 7.108.0-2 (#2445)
  Keep DuckDuckGo Settings after Fire Button (#2444)
  Release 7.108.0-1 (#2440)
  Release 7.107.1-1 (#2439)
  Updates internal user flag to reset state (#2438)
  Release 7.107.1-0 (#2437)
  Hide the debug menu when debug mode is not enabled (#2436)
  Autoconsent 9.7.2 (#2425)
  Release 7.108.0-0 (#2432)
  Autofill: Fix footer sizing for multiline labels (#2422)
  Add rollout for cookie popup management enabled by default (#2373)
  Update BSK with autofill 10.1.0 (#2414)
  Bump submodules/privacy-reference-tests from `a3acc21` to `6b7ad1e` (#2408)
  Add Autoconsent onByDefault subfeature (#2423)
  ...

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants