Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the mock VPN invite code #2442

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Remove the mock VPN invite code #2442

merged 1 commit into from
Feb 6, 2024

Conversation

samsymons
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/414235014887631/1206526539842944/f
Tech Design URL:
CC:

Description:

This PR removes the mock invite code set for VPN users who had access to the debug menu.

Steps to test this PR:

  1. Go into the Debug menu and tap VPN Waitlist
  2. Tap "Set Mock Invite Code"
  3. Relaunch the app from scratch
  4. Go back into the Debug menu and tap VPN Waitlist, make sure that no invite code is set
  5. Finally, do the above steps again but hardcode the debug menu's "Set Mock Invite Code" option to set it to something that isn't the mock value, to test that the delete invite logic will not wipe real codes

Copy Testing:

  • Use of correct apostrophes in new copy, ie ’ rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme
Internal references:

Software Engineering Expectations
Technical Design Template

@samsymons samsymons requested a review from graeme February 6, 2024 04:29
@samsymons samsymons merged commit 1b03c08 into main Feb 6, 2024
10 checks passed
@samsymons samsymons deleted the sam/remove-mock-invite-code branch February 6, 2024 20:39
samsymons added a commit that referenced this pull request Feb 8, 2024
@samsymons
Merge branch 'main' into sam/netp-debug-command-disable-vpn
c31f8ce 
# By Mariusz Śpiewak (11) and others
# Via Bartek Waresiak (3) and others
* main: (52 commits)
  Release 7.108.0-3 (#2454)
  User Authentication (#2431)
  Fix BSK reference to tagged version (#2447)
  Set proper border color for widgets (#2446)
  Check subfeature state before reading rollout data (#2426)
  Remove the mock VPN invite code (#2442)
  Release 7.108.0-2 (#2445)
  Keep DuckDuckGo Settings after Fire Button (#2444)
  Release 7.108.0-1 (#2440)
  Release 7.107.1-1 (#2439)
  Updates internal user flag to reset state (#2438)
  Release 7.107.1-0 (#2437)
  Hide the debug menu when debug mode is not enabled (#2436)
  Autoconsent 9.7.2 (#2425)
  Release 7.108.0-0 (#2432)
  Autofill: Fix footer sizing for multiline labels (#2422)
  Add rollout for cookie popup management enabled by default (#2373)
  Update BSK with autofill 10.1.0 (#2414)
  Bump submodules/privacy-reference-tests from `a3acc21` to `6b7ad1e` (#2408)
  Add Autoconsent onByDefault subfeature (#2423)
  ...

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graeme graeme graeme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samsymons @graeme