27 product variants

[RuslanKostiv1]

Description (*)

Related Pull Requests

magento/catalog-storefront#413
magento/commerce-data-export#8
https://github.com/magento-commerce/graphql/pull/4
https://github.com/magento-commerce/magento2-infrastructure/pull/1368
https://git.corp.adobe.com/ecp/api-protos/pull/22

Fixed Issues (if relevant)

1. Fixes [357.3] Import data to SF Application  magento/catalog-storefront#331
2. Fixes [357.4] GetProductVariants service magento/catalog-storefront#332
3. Fixes [357.6] DeleteProductVariants service magento/catalog-storefront#335

Questions or comments

Code Review Checklist (*)

See detailed checklist

• Story AC is completed
• proposed changes correspond to Magento Technical Vision
• new or changed code is covered with web-api/integration tests (if applicable)
  • expected results in test verified with data from fixture
• no backward incompatible changes
• Export API (et_schema.xml) and SF API schemas (proto schema) are reflected in the codebase
  • prerequisite: story branch created with all needed generated classes according to proposes schema-changes
  • DTO classes do not contain any manual changes (Magento\CatalogExportApi*, Magento\CatalogStorefrontApi*)
• Class usage: magento/catalog-storefront repo don't use directly classes from magento/saas-export repo and vise-verse
  • Check composer.json dependencies
• Legacy code is deleted
  • Any Data Providers present in Connector part (Magento\CatalogStorefrontConnector, Magento*Extractor modules)
  • And Data Providers from Export API (magento/saas-export repo) that is not relevant anymore
  • Any DTO for Export API/SF API which does not reflect current schema: et_schema, proto schema
  • Any “mapper” on Message Broker (between Export API and SF API)
    • if mapper still needed, verify fields used in mapping, remove not relevant fields