Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

27 product variants #8

Merged
merged 14 commits into from
Nov 13, 2020
Merged

27 product variants #8

merged 14 commits into from
Nov 13, 2020

Conversation

RuslanKostiv1
Copy link
Contributor

@RuslanKostiv1 RuslanKostiv1 commented Nov 10, 2020 •
edited
Loading

Description (*)

Related Pull Requests

magento/catalog-storefront#413
https://github.com/magento-commerce/graphql/pull/4
https://github.com/magento-commerce/magento2-infrastructure/pull/1368
https://git.corp.adobe.com/ecp/api-protos/pull/22
duhon/magento-docker#30

Fixed Issues (if relevant)

  1. Fixes [357.3] Import data to SF Application  catalog-storefront#331
  2. Fixes [357.4] GetProductVariants service catalog-storefront#332
  3. Fixes [357.6] DeleteProductVariants service catalog-storefront#335

Questions or comments

Code Review Checklist (*)

See detailed checklist

  • Story AC is completed
  • proposed changes correspond to Magento Technical Vision
  • new or changed code is covered with web-api/integration tests (if applicable)
    • expected results in test verified with data from fixture
  • no backward incompatible changes
  • Export API (et_schema.xml) and SF API schemas (proto schema) are reflected in the codebase
    • prerequisite: story branch created with all needed generated classes according to proposes schema-changes
    • DTO classes do not contain any manual changes (Magento\CatalogExportApi*, Magento\CatalogStorefrontApi*)
  • Class usage: magento/catalog-storefront repo don't use directly classes from magento/saas-export repo and vise-verse
    • Check composer.json dependencies
  • Legacy code is deleted
    • Any Data Providers present in Connector part (Magento\CatalogStorefrontConnector, Magento*Extractor modules)
    • And Data Providers from Export API (magento/saas-export repo) that is not relevant anymore
    • Any DTO for Export API/SF API which does not reflect current schema: et_schema, proto schema
    • Any “mapper” on Message Broker (between Export API and SF API)
      • if mapper still needed, verify fields used in mapping, remove not relevant fields

jekabs and others added 10 commits November 5, 2020 16:14
Product variants
0c547b5 
-Module and changes to existing infrastructure to support product variants
-Added configurable product variants
-Added tests for product variants
Product variants
3aea827 
Minor syntax fixes
Product variants
e2e18be 
-Changed entity type to string
Product variants
3409931 
-Test fixes
Product variants
5472742 
-Minor fixes
Product variants
b24c4a5 
-Moved test from variants to configurable variants and other minor adjustments
Product variants
d7dc7a9
Product variants
b2102bf
Product variants
92f9286 
-Comment fix
-Made product variant id provider params more defined
@RuslanKostiv1
27: Product variants
d4b7728
This was referenced Nov 10, 2020
Merged
Merged
mmansoor-magento pushed a commit that referenced this pull request Nov 12, 2020
@akaplya
Merge pull request #8 from magento-commerce/fix-SEARCH-510
60445ea 
Fixed issue with indexer state
@RuslanKostiv1 RuslanKostiv1 force-pushed the 27_product-variants branch 2 times, most recently from 46d2d59 to d4b7728 Compare November 12, 2020 21:06
@RuslanKostiv1
Copy link
Contributor Author

@magento run all tests

@RuslanKostiv1
Copy link
Contributor Author

@magento import pr to magento-commerce/commerce-data-export

@magento-engcom-team
Copy link

@RuslanKostiv1 the pull request successfully imported.

@mmansoor-magento mmansoor-magento merged commit 738df37 into magento:main Nov 13, 2020
magento-devops-reposync-svc pushed a commit that referenced this pull request Nov 4, 2021
@mslabko
Merge pull request #8 from magento-troll/MDEE-40-real-qty
39cd899 
MDEE-40:[Commerce Export] Implement stock_item_status feed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@RuslanKostiv1 @magento-engcom-team @mmansoor-magento