Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17206] Restore participant domainID tag in XML profile #464

Merged
merged 3 commits into from
Feb 28, 2023

Conversation

JesusPoderoso
Copy link
Contributor

@JesusPoderoso JesusPoderoso commented Feb 20, 2023

  • Restore <domainId> tag in documentation
  • Restore tag in ALL documentation XMLs

Rebased #455

This pull request should be merged right after #455 gets merged

@JesusPoderoso
Copy link
Contributor Author

@richiprosima Please test this

@JesusPoderoso JesusPoderoso changed the title Restore participant domainID tag in XML profile [17206] Restore participant domainID tag in XML profile Feb 20, 2023
@JesusPoderoso JesusPoderoso marked this pull request as ready for review February 20, 2023 14:09
@JesusPoderoso JesusPoderoso force-pushed the feature/restore_participant_domainID branch from ec42d1d to 93f25fa Compare February 20, 2023 14:13
@JLBuenoLopez
Copy link
Contributor

@richiprosima please test this

docs/fastdds/xml_configuration/domainparticipant.rst Outdated Show resolved Hide resolved
docs/fastdds/xml_configuration/domainparticipant.rst Outdated Show resolved Hide resolved
code/XMLTester.xml Outdated Show resolved Hide resolved
JLBuenoLopez
JLBuenoLopez previously approved these changes Feb 21, 2023
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@JesusPoderoso JesusPoderoso merged commit 856b9ec into master Feb 28, 2023
@JesusPoderoso JesusPoderoso deleted the feature/restore_participant_domainID branch February 28, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants