Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up Che Theia specific tests and page objects #22052

Merged
merged 2 commits into from
Mar 20, 2023
Merged

Clean up Che Theia specific tests and page objects #22052

merged 2 commits into from
Mar 20, 2023

Conversation

nallikaea
Copy link
Contributor

@nallikaea nallikaea commented Mar 9, 2023 •
edited
Loading

@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. target/branch Indicates that a PR will be merged into a branch other than master. labels Mar 9, 2023
@nallikaea nallikaea changed the title Clean up Che Theia specific tests and page objects #22043 Clean up Che Theia specific tests and page objects Mar 9, 2023
@nallikaea nallikaea force-pushed the issue#22043 branch 2 times, most recently from 8155dca to b379e8d Compare March 10, 2023 12:37
@dmytro-ndp
Copy link
Contributor

dmytro-ndp commented Mar 10, 2023 •
edited
Loading

@nallikaea: impressive work!
Could you, please, also check that che-e2e docker image is built, and che-code editor tests could be executed both locally and using che-e2e docker image?

ScrewTSW
ScrewTSW reviewed Mar 10, 2023
View reviewed changes
Copy link
Member

@ScrewTSW ScrewTSW left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few general questions, really awesome piece of work

tests/e2e/configs/inversify.types.ts Show resolved Hide resolved
tests/e2e/package.json Show resolved Hide resolved
tests/e2e/specs/devfiles/EmptyWorkspace.spec.ts Show resolved Hide resolved
@dmytro-ndp
Copy link
Contributor

@nallikaea : would you prepare MR to fix downstream tests as well?

@nallikaea
Copy link
Contributor Author

@nallikaea: impressive work! Could you, please, also check that che-e2e docker image is built, and che-code editor tests could be executed both locally and using che-e2e docker image?

image
@dmytro-ndp @ScrewTSW @musienko-maxim

dmytro-ndp
dmytro-ndp reviewed Mar 10, 2023
View reviewed changes
tests/e2e/package.json
"test-code": "./generateIndex.sh && npm run lint && npm run tsc && mocha --config mocha-che-code.json",
"test-happy-path-code": "./generateIndex.sh && npm run lint && npm run tsc && mocha --config mocha-happy-path-che-code.json",
"test-devworkspace-happy-path-code": "./generateIndex.sh && npm run lint && npm run tsc && mocha --config mocha-devworkspace-happy-path-che-code.json",
"test-empty-workspace-devworkspace-happy-path-code": "./generateIndex.sh && npm run lint && npm run tsc && mocha --config mocha-empty-workspace-devworkspace-happy-path-che-code.json",
Copy link
Contributor

@dmytro-ndp dmytro-ndp Mar 10, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nallikaea : test-empty-workspace-devworkspace-happy-path-code command is used to verify che-operator repo PR:

If you are going to remove it, please prepare PR to https://github.com/eclipse-che/che-operator with alternative command.

@tolusha cc

Copy link
Contributor Author

@nallikaea nallikaea Mar 20, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Updated oc-test-happy-path.sh according to new test scripts in "Che" project che-operator#1641
  2. eede731

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, don't remove test-empty-workspace-devworkspace-happy-path-code until the PR is merged

@nallikaea nallikaea mentioned this pull request Mar 20, 2023
Merged
10 tasks
dmytro-ndp
dmytro-ndp approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@dmytro-ndp dmytro-ndp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to merge

Maryna Dolhalova added 2 commits March 20, 2023 20:20
Clean up Che Theia specific tests and page objects from Eclipse Che t…
0acc4d2 
…ypescript functional tests eclipse-che#22043

Signed-off-by: mdolhalo <mdolhalo@redhat.com>
Updated pod-che-happy-path.yaml according to new test scripts eclipse…
5ec8444 
…-che#22043

Signed-off-by: mdolhalo <mdolhalo@redhat.com>
@dmytro-ndp dmytro-ndp merged commit 13e3caa into eclipse-che:main Mar 20, 2023
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Mar 20, 2023
This was referenced Mar 22, 2023
Merged
Merged
@nallikaea nallikaea deleted the issue#22043 branch April 13, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tolusha tolusha tolusha left review comments

@ScrewTSW ScrewTSW ScrewTSW approved these changes

@musienko-maxim musienko-maxim musienko-maxim approved these changes

@dmytro-ndp dmytro-ndp dmytro-ndp approved these changes

@nickboldt nickboldt Awaiting requested review from nickboldt

Assignees
No one assigned
Labels
target/branch Indicates that a PR will be merged into a branch other than master.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nallikaea @dmytro-ndp @musienko-maxim @tolusha @ScrewTSW @che-bot