Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using the RecordingModelResourceManager creates a lot of unnecessary adapters #123

Closed
martin-fleck-at opened this issue Sep 8, 2021 · 0 comments · Fixed by #124
Closed

Using the RecordingModelResourceManager creates a lot of unnecessary adapters #123

martin-fleck-at opened this issue Sep 8, 2021 · 0 comments · Fixed by #124
Assignees
@ndoschek
Labels
bug Something isn't working

Comments

@martin-fleck-at
Copy link
Contributor

When executing command or triggering an undo/redo we always create a new ChangeRecoder which installs an adapter on the resource set and all elements below (resources, EObjects). First, these recorders are never disposed so the adapter list grows and grows. Second, I believe there is no need to create new recorders all the time since we could simply re-use the recorder that is attached to the transactional domain.
@martin-fleck-at martin-fleck-at added the bug Something isn't working label Sep 8, 2021
ndoschek added a commit that referenced this issue Sep 8, 2021
@ndoschek
#123 Reuse TransactionChangeRecorder in RecordingModelResourceManager
cc332a4 
Using the RecordingModelResourceManager creates a lot of unnecessary adapters, therefore reuse the TransactionChangeRecorder from the EditingDomain
@ndoschek ndoschek mentioned this issue Sep 8, 2021
Merged
ndoschek added a commit that referenced this issue Sep 9, 2021
@ndoschek
#123 Reuse TransactionChangeRecorder in RecordingModelResourceManager
fd142be 
Using the RecordingModelResourceManager creates a lot of unnecessary adapters, therefore reuse the TransactionChangeRecorder from the EditingDomain
ndoschek added a commit that referenced this issue Sep 9, 2021
@ndoschek
#123 Reuse TransactionChangeRecorder in RecordingModelResourceManager
3543c2c 
Using the RecordingModelResourceManager creates a lot of unnecessary adapters, therefore reuse the TransactionChangeRecorder from the EditingDomain
ndoschek added a commit that referenced this issue Sep 13, 2021
@ndoschek
Merge pull request #124 from /issues/123
71ab59f 
#125, #123, #117 Fix dependencies, reuse TransactionChangeRecorder and use generic stand-in for contributors/developers
ndoschek added a commit that referenced this issue Sep 28, 2021
@ndoschek
#123 Ensure ChangeRecorder is disposed
3ee6ecd 
To ensure the changeDescription object is not null, do not reuse the TransactionChangeRecorder, but create a ChangeRecorder and ensure it is disposed to avoid leftover adapters
martin-fleck-at pushed a commit that referenced this issue Sep 28, 2021
@ndoschek
#123 Ensure ChangeRecorder is disposed (#130)
4a4401e 
To ensure the changeDescription object is not null, do not reuse the TransactionChangeRecorder, but create a ChangeRecorder and ensure it is disposed to avoid leftover adapters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ndoschek ndoschek

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@martin-fleck-at @ndoschek