#125, #123, #117 Fix dependencies, reuse TransactionChangeRecorder and use generic stand-in for contributors/developers #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add missing mandatory dependency org.aopalliance to restore model server launching - Lock jetty version to 9.4.43 as 2021-06 also offers v10 which is compatible with our current versions - Rename r2020-09 to targetplatform and update its occurrences - Use specific versions for emfjson-jackson and jetty update site to speed up targetplatform resolving - Fix Workspace warning (plugin.properties not existing in workspace)
Using the RecordingModelResourceManager creates a lot of unnecessary adapters, therefore reuse the TransactionChangeRecorder from the EditingDomain
ndoschek
changed the title
ndoschek
requested review from
tortmayr
and removed request for
martin-fleck-at
tortmayr
approved these changes
Sep 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #125 Fix dependencies to restore launching and websocket communication
Fixes #117 Use generic stand-in for contributors/developers
Fixes #123 Reuse TransactionChangeRecorder in RecordingModelResourceManager