glsp-server-node

[Mansalek]

Hi,
I have been trying to run the example of glsp -theia-integration but with the glsp server node (https://github.com/eclipse-glsp/glsp-server-node) .
Having already installed all the necessary dependencies and built the project as specified , I'm still not able to run it without errors.
Here are my logs , any help would be appreciated .

[sgraband]

Hey @Mansalek,

does it work with the Java-based GLSP server?

This seems like a windows path issue:

Could not load model from file: /c:/...

I think the leading / should not be there.

You could try to add a .substring(1) here: https://github.com/eclipse-glsp/glsp-theia-integration/blob/f658c13ad3e994969b2fb8120592f929d32c1510/packages/theia-integration/src/browser/diagram/glsp-diagram-widget.ts#L93. If this is indeed the problem it should work in the meantime for you and we can provide a fix as soon as possible.

[Mansalek]

Hey @Mansalek,

does it work with the Java-based GLSP server?

This seems like a windows path issue:

Could not load model from file: /c:/...

I think the leading / should not be there.

You could try to add a .substring(1) here: https://github.com/eclipse-glsp/glsp-theia-integration/blob/f658c13ad3e994969b2fb8120592f929d32c1510/packages/theia-integration/src/browser/diagram/glsp-diagram-widget.ts#L93. If this is indeed the problem it should work in the meantime for you and we can provide a fix as soon as possible.

Thank you , it works perfectly right now . Seems weird but cant' complain.
Have a good day

[sgraband]

I opened an issue, where you can track the progress of a potential fix.

[Mansalek]

reviving this thread just to tell you that this bug(the leading / ) reoccurs within the new theia example (https://github.com/eclipse-glsp/glsp-examples/tree/master/project-templates/node-json-theia)
But this time we can't use the same workaround in the glsp-diagram-widget by adding substring(1)
Any potential fix?

[tortmayr]

I have opened a PR for the Theia integration that should fix OS related URI issues. Once the PR is merged we can update the project templates.

[Mansalek]

I have opened a PR for the Theia integration that should fix OS related URI issues. Once the PR is merged we can update the project templates.

Does that also solve the node-json-theia project template issue? because it's the same one

[planger]

Yes it should also fix the issue in the node-json-theia project template. However, the node-json-theia project template hasn't been upgraded yet to the fixed glsp-theia-integration build and Theia 1.25.0. It is still yarn.locked to 1.24.0 and a glsp-theia-integration version before the PR @tortmayr mentioned above.

Once we upgraded the example it should work. We should be able to do that at latest next week.

[tortmayr]

@Mansalek I have opened a PR for the project templates. Amongst other things this should solve the pathing issue under Windows