Drain nodes in parallel #4864
Merged
Drain nodes in parallel #4864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aclevername
force-pushed
the
parallel-drain
branch
from
0316346 to
6d4c77c
Compare
aclevername
commented
Mar 2, 2022
aclevername
commented
Mar 2, 2022
| @@ -524,6 +525,12 @@ func NewDeleteNodeGroupLoader(cmd *Cmd, ng *api.NodeGroup, ngFilter *filter.Node | |||
| return ErrMustBeSet("--name") | |||
| } | |||
|
|
|||
| if flag := l.CobraCommand.Flag("parallel"); flag != nil && flag.Changed { | |||
There was a problem hiding this comment.
its always an int since the flag type enforces it
aclevername
commented
Mar 2, 2022
aclevername
force-pushed
the
parallel-drain
branch
from
efc559a to
9f8af53
Compare
aclevername
force-pushed
the
parallel-drain
branch
2 times, most recently
from
1c1d2be to
6129061
Compare
Skarlso
reviewed
Mar 2, 2022
Skarlso
reviewed
Mar 2, 2022
Skarlso
reviewed
Mar 2, 2022
Skarlso
reviewed
Mar 2, 2022
aclevername
force-pushed
the
parallel-drain
branch
from
b9d477d to
76e600b
Compare
aclevername
force-pushed
the
parallel-drain
branch
from
76e600b to
4d5b7d0
Compare
Skarlso
approved these changes
Mar 10, 2022
Callisto13
approved these changes
Mar 10, 2022
There was a problem hiding this comment.
Awesome! Wanted to ask a Qs before reviewing more! It's also worth adding something to the docs here https://eksctl.io/usage/managing-nodegroups/#deleting-and-draining :)
added 2 commits
March 10, 2022 16:49
aclevername
force-pushed
the
parallel-drain
branch
from
93f80ac to
29641dd
Compare
Added 😄 |
Himangini
reviewed
Mar 11, 2022
|
@aclevername can we wait to merge this on Monday so that it goes in the next release? :) Today's release needs a little bit of extra TLC. :D |
aclevername
added a commit
that referenced
this pull request
Mar 17, 2022
This reverts commit 391a6ce.
aclevername
added a commit
that referenced
this pull request
Mar 17, 2022
aclevername
pushed a commit
that referenced
this pull request
Mar 17, 2022
aclevername
added a commit
that referenced
this pull request
Mar 22, 2022
* Revert "Revert "Drain nodes in parallel (#4864)" (#4964)" This reverts commit 00f5fcf. * set value in delete cluster * Update pkg/drain/nodegroup.go Co-authored-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com> * Update pkg/drain/nodegroup.go Co-authored-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com> * update unit tests Co-authored-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #4705
Adds support for providing
--parallel <value>(open to renaming!) flag todelete/drain nodegroupthat will mean the nodegroups are drained in parallel. I've set a upper limit of 25 to match our k8s client. example belowTesting
50 node cluster with a 1000 pods deployment
Before:
eksctl drain nodegroup --cluster jk --name ng-1would take4:40.22to complete:After:
With
--parallelset to 20eksctl drain nodegroup --cluster jk --name ng-1 --parallel 20would take1:24.77to complete: