Revert "Drain nodes in parallel" #4964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 391a6ce.
Skarlso
approved these changes
Mar 17, 2022
Himangini
approved these changes
Mar 17, 2022
aclevername
pushed a commit
that referenced
this pull request
Mar 17, 2022
aclevername
added a commit
that referenced
this pull request
Mar 22, 2022
* Revert "Revert "Drain nodes in parallel (#4864)" (#4964)" This reverts commit 00f5fcf. * set value in delete cluster * Update pkg/drain/nodegroup.go Co-authored-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com> * Update pkg/drain/nodegroup.go Co-authored-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com> * update unit tests Co-authored-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #4864
causing failing integration tests. Debugging locally