Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drain nodes in parallel #4966

Merged
merged 7 commits into from
Mar 22, 2022
Merged

Drain nodes in parallel #4966

merged 7 commits into from
Mar 22, 2022

Conversation

aclevername
Copy link
Contributor

@aclevername aclevername commented Mar 17, 2022 •
edited
Loading

Description

Bring back #4864

1 new commit added to ensure delete cluster sets the parallel limit

To review just look at the latest commit

addon, cluster_dns and existing_vpc integration tests all passing:

[0] Ginkgo ran 1 suite in 25m33.42732661s
[0] Test Suite Passed
[0]=================================== Done ===================================
2022/03/17 11:21:05 ================== Summary ================================
[0] Ran 2 of 2 Specs in 1523.222 seconds
[0] SUCCESS! -- 2 Passed | 0 Failed | 0 Pending | 0 Skipped
[0] PASS
[0]




[0]
[0] Ginkgo ran 1 suite in 25m35.491334968s
[0] Test Suite Passed
[0]=================================== Done ===================================
2022/03/17 11:21:07 ================== Summary ================================
[0] Ran 1 of 1 Specs in 1525.000 seconds
[0] SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 0 Skipped
[0] PASS
[0]


[0]
[0] Ginkgo ran 1 suite in 22m5.420170687s
[0] Test Suite Passed
[0]=================================== Done ===================================
2022/03/17 11:17:37 ================== Summary ================================
[0] Ran 1 of 1 Specs in 1314.836 seconds
[0] SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 0 Skipped
[0] PASS

@aclevername aclevername added the skip-release-notes Causes PR not to show in release notes label Mar 17, 2022
@aclevername aclevername changed the title Drain parallel Drain nodes in parallel Mar 17, 2022
@aclevername aclevername requested a review from a team March 17, 2022 10:48
Skarlso
Skarlso reviewed Mar 17, 2022
View reviewed changes
Skarlso
Skarlso reviewed Mar 17, 2022
View reviewed changes
aclevername and others added 2 commits March 17, 2022 10:48
@aclevername @Skarlso
Update pkg/drain/nodegroup.go
e94b098 
Co-authored-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
@aclevername @Skarlso
Update pkg/drain/nodegroup.go
95ca333 
Co-authored-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
Skarlso
Skarlso approved these changes Mar 17, 2022
View reviewed changes
Copy link
Contributor

@Skarlso Skarlso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two nits, then LGTM :) Again :DDDD

@aclevername aclevername requested a review from a team March 17, 2022 12:21
Himangini
Himangini approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@Himangini Himangini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@aclevername aclevername merged commit a00d6d1 into main Mar 22, 2022
@aclevername aclevername deleted the drain-parallel-2 branch March 22, 2022 09:39
@aclevername aclevername mentioned this pull request Mar 22, 2022
Closed
@hspencer77 hspencer77 mentioned this pull request Jul 8, 2022
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skarlso Skarlso Skarlso approved these changes

@Himangini Himangini Himangini approved these changes

Assignees
No one assigned
Labels
skip-release-notes Causes PR not to show in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aclevername @Skarlso @Himangini