buildkite(scripts): refactor common scripts #8365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v1v
added
skip-changelog
backport-active-all
|
Contributor
💚 Build Succeeded
cc @v1v |
oakrizan
approved these changes
Jun 10, 2025
dliappis
approved these changes
Jun 10, 2025
Contributor
dliappis
left a comment
dliappis
left a comment
There was a problem hiding this comment.
LGTM it's so great to see unnecessary scripts/files getting removed!
I also couldn't find any uses of google_cloud_auth() so it's great that it gets removed from both.
Contributor
|
@Mergifyio backport 8.17 8.18 8.19 9.0 |
Contributor
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jun 10, 2025
(cherry picked from commit c01278b)
mergify bot
pushed a commit
that referenced
this pull request
Jun 10, 2025
(cherry picked from commit c01278b)
mergify bot
pushed a commit
that referenced
this pull request
Jun 10, 2025
(cherry picked from commit c01278b)
This was referenced Jun 10, 2025
Member
Author
|
@Mergifyio backport 9.0 |
Contributor
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jun 10, 2025
(cherry picked from commit c01278b)
8 tasks
v1v
pushed a commit
that referenced
this pull request
Jun 10, 2025
v1v
pushed a commit
that referenced
this pull request
Jun 10, 2025
v1v
pushed a commit
that referenced
this pull request
Jun 10, 2025
v1v
pushed a commit
that referenced
this pull request
Jun 11, 2025
v1v
added a commit
that referenced
this pull request
Jun 12, 2025
…ts-oblt-cli * feature/serverless-its-oblt-cli: (51 commits) as agreed let's move the group to the kb.integration pipeline Update .github/workflows/serverless-project.yml ci: invoke serverless integration tests package from BK github-actions: create a serverless project daily [tests] split up serverless and resource leaks integration tests (#8396) chore: Update to elastic/beats@dfdc12e33de0 (#8446) Lock upgrade marker (#8254) build(deps): bump github.com/elastic/elastic-agent-system-metrics from 0.11.12 to 0.11.13 (#8420) Add docker image name template and renamed fips cloud specs (#8429) buildkite(scripts): refactor common scripts (#8365) Use require.Eventually to try and address flakiness (#8421) Fix pre-command to support extended testing (#8418) [Automation] Bump Golang version to 1.24.4 (#8384) chore: Update to elastic/beats@aed2a8b768bd (#8423) [main][Automation] Update versions (#8425) Add Pipeline to deploy custom agent image for FIPS testing (#8035) ci: automatically update OTel components (#8288) [Automation] Bump VM Image version to 1749258065 (#8390) fix: increase context timeout to accommodate for slower machines in Test_checkForUnprivilegedVault (#8374) otel: add cumulativetodeltaprocessor to EDOT collector (#8372) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
common2.shWhy is it important?
Tidy up the code and the usage:
common2.shdoes not contain much logic, and some env variables are already created in thepre-commandhook when it runs thecommon.shscript.common2.shname is not clear enough.google_cloud_authfunction is not actually called anywhere as far I can see at the GitHub search.Checklist
./changelog/fragmentsusing the changelog toolDisruptive User Impact
How to test this PR locally
Related issues
Questions to ask yourself