Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable ScaleType.Time independently of timezone #130

Closed
1 of 2 tasks
markov00 opened this issue Mar 29, 2019 · 1 comment · Fixed by #151
Closed
1 of 2 tasks

Enable ScaleType.Time independently of timezone #130

markov00 opened this issue Mar 29, 2019 · 1 comment · Fixed by #151
Assignees
@markov00
Labels
bug Something isn't working kibana cross issue Has a Kibana issue counterpart released Issue released publicly

Comments

@markov00
Copy link
Member

Describe the bug
The current implementation requires the data to be in UTC to work correctly.
We need to digest any type of date independently of the timezone.

Errors in browser console
If applicable, add any console error.

Kibana Cross Issues

Checklist

  • every related Kibana issue is listed under Kibana Cross Issues list
  • kibana cross issue tag is associated to the issue if any kibana cross issue is present
@markov00 markov00 added bug Something isn't working kibana cross issue Has a Kibana issue counterpart labels Mar 29, 2019
@markov00 markov00 self-assigned this Mar 29, 2019
@markov00 markov00 added this to the 7.1 milestone Mar 29, 2019
This was referenced Apr 2, 2019
Closed
Closed
@markov00 markov00 mentioned this issue Apr 5, 2019
Merged
3 tasks
markov00 added a commit to markov00/elastic-charts that referenced this issue Apr 5, 2019
@markov00
fix(timescale): consider timezone on axis ticks
7bccb24 
The d3-scale function, used to compute axis ticks, compute a discrete and nice rounded number of
ticks on a time scale. By the way, this rounding is applied using UTC or local timezone, meaning
that we cannot display a nicely rounded tick if we want to display data in a timezone different from
the local or utc one. This commit includes a new optional prop to each series `timeZone` that can be
used to configure this behaviour (default to utc).

fix elastic#130
markov00 added a commit that referenced this issue Apr 8, 2019
@markov00
fix(timescale): consider timezone on axis ticks (#151)
d860c97 
The d3-scale function, used to compute axis ticks, compute a discrete and nice rounded number of ticks on a time scale. By the way, this rounding is applied using UTC or local timezone, meaning
that we cannot display a nicely rounded tick if we want to display data in a timezone different from
the local or utc one. This commit includes a new optional prop to each series `timeZone` that can be used to configure this behaviour (default to utc).

fix #130
markov00 pushed a commit that referenced this issue Apr 8, 2019
@semantic-release-bot
chore(release): 3.7.2 [skip ci]
22659de 
## [3.7.2](v3.7.1...v3.7.2) (2019-04-08)

### Bug Fixes

* **timescale:** consider timezone on axis ticks ([#151](#151)) ([d860c97](d860c97)), closes [#130](#130)
@markov00
Copy link
Member Author

markov00 commented Apr 8, 2019

🎉 This issue has been resolved in version 3.7.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Apr 8, 2019
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
@semantic-release-bot
chore(release): 3.7.2 [skip ci]
0ddc493 
## [3.7.2](elastic/elastic-charts@v3.7.1...v3.7.2) (2019-04-08)

### Bug Fixes

* **timescale:** consider timezone on axis ticks ([opensearch-project#151](elastic/elastic-charts#151)) ([e4ee93e](elastic/elastic-charts@e4ee93e)), closes [opensearch-project#130](elastic/elastic-charts#130)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markov00 markov00

Labels
bug Something isn't working kibana cross issue Has a Kibana issue counterpart released Issue released publicly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(timescale): consider timezone on axis ticks markov00/elastic-charts
1 participant
@markov00