-
Notifications
You must be signed in to change notification settings - Fork 25.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct documentation of discovery.zen.ping.unicast.hosts regarding support for port ranges #15816
Comments
@drekbour Thanks for opening this issue. Do you want to contribute a doc PR to fix that? |
We should probably also throw an exception when a user specifies a port range. |
Remove docs saying that unicast hosts supports port ranges. Relates to #15816
Remove docs saying that unicast hosts supports port ranges. Relates to #15816
I've updated the documentation, but we should still throw an exception when the user specifies a port range. |
Remove docs saying that unicast hosts supports port ranges. Relates to #15816
@clintongormley I'm just getting started with elasticsearch and would to work on this one as my first PR. Can you assign it to me please? |
@nikhilchudekar I can't assign to people outside the organisation, but you're welcome to work on it and to submit a PR referencing this issue eg |
will do, thanks. |
I see a PR that's already addressing this (though it is way back in April 2017). Looks like it has been reviewed, and all that is left is pushing the fix to the repo? @clintongormley I'll move on to something else. |
We are going to open a separate issue for the "throwing an exception". This issue shows that there are related PRs that have been merged. But non of those PRs appear to have been merged into the |
The docs are long-fixed, resolving the headline part of this issue, and I've opened #40786 for the remaining part. |
The documentation of discovery.zen.ping.unicast.hosts explicitly mentions port-ranges but fails to mention that they are not supported and only the first port is checked.
There are several Issues/PRs relating to changing this but none have made it yet so please document that port-range format is allowed but not supported and that if a user wishes to address multiple ports they must do explicitly
https://www.elastic.co/guide/en/elasticsearch/reference/current/modules-discovery-zen.html
#8833 will allow the first two ports to be scanned. Older items relating to this are #99, #7561, #7090, #12999, elastic/elasticsearch-cloud-aws#197
The text was updated successfully, but these errors were encountered: