Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update transforms to be unattended #353

Merged
merged 1 commit into from
Mar 8, 2023
Merged

Conversation

joeypoon
Copy link
Member

@joeypoon joeypoon commented Mar 6, 2023

Change Summary

Update current + united metadata transforms to be settings.unattended: true.

Related: https://github.com/elastic/security-team/issues/6165

Release Target

8.8

For Transform changes:

  • The new transform successfully starts in Kibana

@joeypoon joeypoon requested a review from a team as a code owner March 6, 2023 22:05
@joeypoon joeypoon requested review from pzl and parkiino March 6, 2023 22:05
@elasticmachine
Copy link
Contributor

elasticmachine commented Mar 6, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-08T14:57:29.886+0000

  • Duration: 8 min 6 sec

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@pzl
Copy link
Member

pzl commented Mar 6, 2023

Does fleet respect this settings key? Is the transform installed with this setting?

@joeypoon
Copy link
Member Author

joeypoon commented Mar 6, 2023

Does fleet respect this settings key? Is the transform installed with this setting?

yes and yes. fleet passes the entire transform body to ES without any validation so don't need to add anything there. this won't change the transform functionally. this just tells ES to manage the transform's health and to always retry if in failing state: https://www.elastic.co/guide/en/elasticsearch/reference/current/put-transform.html (sorry no anchors on page, have to search for unattended).

Copy link
Member

@pzl pzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

I bet the linters are complaining about the final newline in the file. Should pass if you remove it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants