Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "update transforms to be unattended (#353)" #359

Merged
merged 2 commits into from
Apr 4, 2023

Conversation

joeypoon
Copy link
Member

@joeypoon joeypoon commented Apr 3, 2023

Change Summary

Revert unattended transform option. This change is causing package install to occasionally fail. Since unattended means the transform will never throw, fleet doesn't reattempt to reinstall the transform destination indices during transient package install failures leaving the destination indices uncreated.

@joeypoon joeypoon requested a review from a team as a code owner April 3, 2023 23:58
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-03T23:58:46.365+0000

  • Duration: 8 min 44 sec

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@kevinlog
Copy link
Contributor

kevinlog commented Apr 4, 2023

checked this out and tried it. Transforms are being installed correctly and I can use the generator to stream data in properly

image

image

@joeypoon joeypoon merged commit f6f8938 into main Apr 4, 2023
@joeypoon joeypoon deleted the fix/revert-unattended branch April 4, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants