Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] remove metadata transform health task #153401

Closed
wants to merge 2 commits into from

Conversation

joeypoon
Copy link
Member

Summary

Remove endpoint metadata transform health task. This is no longer needed as the transforms are now set to be unattended: elastic/endpoint-package#353.

For maintainers

@joeypoon joeypoon added release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution labels Mar 21, 2023
@joeypoon joeypoon force-pushed the chore/remove-transform-task branch from f43e8e7 to 71f8fa6 Compare March 22, 2023 23:22
@joeypoon joeypoon force-pushed the chore/remove-transform-task branch from 71f8fa6 to f45a503 Compare March 23, 2023 22:16
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 432 434 +2

Total ESLint disabled count

id before after diff
securitySolution 512 514 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@joeypoon joeypoon marked this pull request as ready for review March 29, 2023 21:42
@joeypoon joeypoon requested review from a team as code owners March 29, 2023 21:42
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ResponseOps changes LGTM

Copy link
Member

@ashokaditya ashokaditya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@joeypoon
Copy link
Member Author

joeypoon commented Apr 4, 2023

closing this for now as there are some issues preventing us from switching to unattended transforms: elastic/endpoint-package#359

@joeypoon joeypoon closed this Apr 4, 2023
@pzl pzl reopened this Aug 14, 2023
@pzl pzl closed this Aug 14, 2023
@pzl pzl reopened this Nov 2, 2023
@droberts195
Copy link
Contributor

Are you sure you want to remove these checks now the transform is unattended? As far as I can see these checks did more than what an unattended transform will do. These checks appear to reinstall the transforms if somebody deletes them. An unattended transform can still be deleted. If you want to keep that automatic reinstall functionality it may be simplest just to keep all this functionality.

@joeypoon joeypoon closed this Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants