Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate euiThemeVars #8201

Open
weronikaolejniczak opened this issue Dec 4, 2024 · 2 comments · May be fixed by elastic/kibana#202943
Open

Deprecate euiThemeVars #8201

weronikaolejniczak opened this issue Dec 4, 2024 · 2 comments · May be fixed by elastic/kibana#202943
Assignees

Comments

@weronikaolejniczak
Copy link
Contributor

weronikaolejniczak commented Dec 4, 2024

Summary:

The purpose of this ticket is to deprecate euiThemeVars in Kibana.

References:

@weronikaolejniczak weronikaolejniczak self-assigned this Dec 4, 2024
@weronikaolejniczak weronikaolejniczak changed the title Deprecate euiThemeVars and JSON exports Deprecate euiThemeVars Dec 5, 2024
@JasonStoltz
Copy link
Member

We have a eslint rule with a rule -- we want to make Kibana UI package a warning, but restricted imports is set to error. But can just clone a rule, which is what Weronika did.

Put a PR in for Kibana, but rule is not working.

@JasonStoltz
Copy link
Member

2 parts to this:

Get this merged: #8201 -- so Kibana folks can immediately see things shouldn't be used, but CI won't get choked up on it.

Test eslint locally in Kibana to verify it works -- release plugin and bump dependency in Cloud
Lene mentioned that we don't have a good way to deprecate these for server-side usage yet.

We should mark it for deprecation to discourage new usage and get folks to remove their existing usage, but we still need to help folks with server-side usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants