-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: deprecate euiThemeVars #202943
base: main
Are you sure you want to change the base?
chore: deprecate euiThemeVars #202943
Conversation
@elasticmachine merge upstream |
💔 Build Failed
Failed CI Steps
Test Failures
Metrics [docs]Unknown metric groupsReferences to deprecated APIs
History |
It looks like this whole package should be deprecated. @mistic @elastic/kibana-operations how do we typically deprecate an entire package in Kibana, (and evangelize that)? Is it an eslint rule? |
@clintandrewhall that makes sense! Looking at Lines 195 to 274 in e067fa2
|
Adding the package to |
@elastic/kibana-operations it's been suggested to mark I could put them into an override of the |
@weronikaolejniczak Creating an override with a warning is correct. |
@Ikuni17 it's not possible in ESLint to define multiple error levels for a rule at once. A workaround is cloning For now, at the very least, I'd merge this Let me know how that sounds for you! cc @JasonStoltz |
@Ikuni17 @clintandrewhall I'd appreciate a decision on this one so we can close it 🙏🏻 |
Summary
As we transition from
euiThemeVars
(@kbn/ui-theme
) touseEuiTheme
(@elastic/eui
), we plan to include a deprecation notice to discourage the use of the legacy JSON tokens.Context: #199715 (comment)
closes #8201