Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiImage] Expose full screen state #6504

Merged
merged 4 commits into from
Jan 4, 2023
Merged

[EuiImage] Expose full screen state #6504

merged 4 commits into from
Jan 4, 2023

Conversation

shahzad31
Copy link
Contributor

Summary

We are using EuiImage full screen state and in some case we needed to show caption only when image is in full screen mode. So we need full screen state to determine that. This PR expose the full screen state of the component via callback.

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6504/

elizabetdev
elizabetdev suggested changes Jan 3, 2023
View reviewed changes
Copy link
Contributor

@elizabetdev elizabetdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @shahzad31 for adding this feature. I tested it locally and it works well.

Can you add a changelog entry in /upcoming_changelogs/6504.md folder with your PR number?

@shahzad31
Copy link
Contributor Author

Thanks, @shahzad31 for adding this feature. I tested it locally and it works well.

Can you add a changelog entry in /upcoming_changelogs/6504.md folder with your PR number?

Interesting i thought , change log entries can be automated. I will do it. CI is fialing because of missing changelog?

@elizabetdev
Copy link
Contributor

It seems that the CI is failing because of:

21:46:44 /app/src/components/image/image_fullscreen_wrapper.tsx
21:46:44   35:15  error  Insert `,`  prettier/prettier
21:46:44 
21:46:44 /app/src/components/image/image_wrapper.tsx
21:46:44   33:15  error  Insert `,`  prettier/prettier
21:46:44 
21:46:44 ✖ 2 problems (2 errors, 0 warnings)
21:46:44   2 errors and 0 warnings potentially fixable with the `--fix` option.

@shahzad31 shahzad31 requested a review from elizabetdev January 3, 2023 16:45
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6504/

@shahzad31
Copy link
Contributor Author

Thank you for taking care of those @miukimiu 👍🏼

elizabetdev
elizabetdev approved these changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@elizabetdev elizabetdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @shahzad31. I pushed some prettier fixes and the CL entry.

LGTM! 🎉

@shahzad31 shahzad31 merged commit a730de6 into elastic:main Jan 4, 2023
@shahzad31 shahzad31 deleted the expose-full-screen-state branch January 4, 2023 12:12
@cee-chen cee-chen mentioned this pull request Jan 10, 2023
Merged
cee-chen added a commit to elastic/kibana that referenced this pull request Jan 13, 2023
@cee-chen @kibanamachine @JasonStoltz
Upgrade EUI to v72.2.0 (#148687)
b86f3ea 
## Summary

`eui@71.1.0` ⏩ `eui@72.2.0`

---

- Added `onFullScreen` callback to expose the `isFullScreen` state of
the `EuiImage` ([#6504](elastic/eui#6504))
- Added an extra spacing between the title and subtitle to `EuiTour`
([#6512](elastic/eui#6512))
- Updated `EuiText.blockquote` styles to match the
`EuiMarkdownFormat.blockquote` styles
([#6514](elastic/eui#6514))
- Added the `repositionOnScroll` prop to `EuiToolTip`
([#6515](elastic/eui#6515))

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Jason Stoltzfus <jason.stoltzfus@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elizabetdev elizabetdev elizabetdev approved these changes

Assignees
No one assigned
Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shahzad31 @kibanamachine @elizabetdev