Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[plugin installer] Change tests to not store files in the application directory #6512

Closed
BigFunger opened this issue Mar 11, 2016 · 0 comments
Closed

[plugin installer] Change tests to not store files in the application directory #6512

BigFunger opened this issue Mar 11, 2016 · 0 comments
Assignees
@BigFunger
Labels
chore

Comments

@BigFunger
Copy link
Contributor

Suggestions from PR #6402

@epixa Not a big deal, but it'd probably be better to dump this sort of stuff into the operating system tmp directory rather than writing to the project itself. The tmp module is awesome for this as it'll automatically clean up when the process is killed, which means if the tests were killed while they were running, there wouldn't be leftover artifacts.

If you do end up keeping the mkdirp/current directory approach, please add this path to the .gitignore for when the tests are killed.

Actually, you're probably better off just circumventing the actual file system in your tests altogether. Something like mock-fs would allow you to mock away the file system entirely, which means the tests would run a lot faster and you would never run into issues with orphaned artifacts and the like.

tmp module
mock-fs module
@BigFunger BigFunger self-assigned this Mar 11, 2016
@kobelb kobelb closed this as completed Aug 7, 2018
cee-chen added a commit that referenced this issue Jan 13, 2023
@cee-chen @kibanamachine @JasonStoltz
Upgrade EUI to v72.2.0 (#148687)
b86f3ea 
## Summary

`eui@71.1.0` ⏩ `eui@72.2.0`

---

- Added `onFullScreen` callback to expose the `isFullScreen` state of
the `EuiImage` ([#6504](elastic/eui#6504))
- Added an extra spacing between the title and subtitle to `EuiTour`
([#6512](elastic/eui#6512))
- Updated `EuiText.blockquote` styles to match the
`EuiMarkdownFormat.blockquote` styles
([#6514](elastic/eui#6514))
- Added the `repositionOnScroll` prop to `EuiToolTip`
([#6515](elastic/eui#6515))

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Jason Stoltzfus <jason.stoltzfus@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BigFunger BigFunger

Labels
chore
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kobelb @BigFunger