Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiText] Add new blockquotes styles #6514

Merged
merged 6 commits into from
Jan 10, 2023

Conversation

elizabetdev
Copy link
Contributor

@elizabetdev elizabetdev commented Jan 5, 2023

Summary

This PR updates the EuiText.blockquote styles to match the EuiMarkdownFormat.blockquote styles. Blockquotes are normally used in docs sites so we should have styles that users are more familiar with.

Closes #6511.

euitext blockquotes@2x

QA

Remove or strikethrough items that do not apply to your PR.

General checklist

  • Checked in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • Props have proper autodocs and playground toggles
  • Added documentation
  • Checked Code Sandbox works for any docs examples
  • Added or updated jest and cypress tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • Updated the Figma library counterpart
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6514/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6514/

@elizabetdev elizabetdev marked this pull request as ready for review January 9, 2023 17:05
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6514/

Copy link
Contributor

@cee-chen cee-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look great to me!

@elizabetdev elizabetdev merged commit 85bfbd2 into elastic:main Jan 10, 2023
cee-chen added a commit to elastic/kibana that referenced this pull request Jan 13, 2023
## Summary

`eui@71.1.0` ⏩ `eui@72.2.0`

---

- Added `onFullScreen` callback to expose the `isFullScreen` state of
the `EuiImage` ([#6504](elastic/eui#6504))
- Added an extra spacing between the title and subtitle to `EuiTour`
([#6512](elastic/eui#6512))
- Updated `EuiText.blockquote` styles to match the
`EuiMarkdownFormat.blockquote` styles
([#6514](elastic/eui#6514))
- Added the `repositionOnScroll` prop to `EuiToolTip`
([#6515](elastic/eui#6515))

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Jason Stoltzfus <jason.stoltzfus@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[EuiText] Add new blockquotes styles
3 participants