Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiSearchBar] Allow @ special character in query string searches #7702

Merged
merged 2 commits into from
Apr 23, 2024
Merged

[EuiSearchBar] Allow @ special character in query string searches #7702

merged 2 commits into from
Apr 23, 2024

Conversation

cee-chen
Copy link
Member

@cee-chen cee-chen commented Apr 22, 2024 •
edited
Loading

Summary

@iverase's team needs the ability to search for more special characters in EuiInMemoryTable's search bar (uses EuiSearchBar under the hood). They primarily need the special characters * (already supported) and @ (in this PR).

(See also #7160 (comment))

QA

General checklist

  • Browser QA - N/A, not a frontend/UI change
  • Docs site QA - N/A, not documented
  • Code quality checklist
  • Release checklist
    • A changelog entry exists and is marked appropriately.
  • Designer checklist - N/A

@kibanamachine
Copy link

Preview staging links for this PR:

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

@cee-chen cee-chen marked this pull request as ready for review April 23, 2024 15:18
@cee-chen cee-chen requested a review from a team as a code owner April 23, 2024 15:18
mgadewoll
mgadewoll approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@mgadewoll mgadewoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🐈‍⬛ LGTM!

@cee-chen cee-chen merged commit e33f59f into elastic:main Apr 23, 2024
8 checks passed
@cee-chen cee-chen deleted the search-bar/special-chars branch April 23, 2024 19:16
@cee-chen cee-chen mentioned this pull request Apr 29, 2024
Merged
@sabarasaba sabarasaba mentioned this pull request May 1, 2024
Closed
cee-chen added a commit to elastic/kibana that referenced this pull request May 3, 2024
@cee-chen @tkajtoch
Upgrade EUI to v94.2.1 (#182023)
31e8c54 
`v94.1.0-backport.0` ⏩ `v94.2.1-backport.0`

_[Questions? Please see our Kibana upgrade
FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_

---

##
[`v94.2.1-backport.0`](https://github.com/elastic/eui/releases/v94.2.1-backport.0)

**This is a backport release only intended for use by Kibana.**

- Reverted the `EuiFlexGroup`/`EuiFlexItem` `component` prop feature due
to Kibana typing issues

## [`v94.2.1`](https://github.com/elastic/eui/releases/v94.2.1)

**Bug fixes**

- Fixed an `EuiTabbedContent` edge case bug that occurred when updated
with a completely different set of `tabs`
([#7713](elastic/eui#7713))
- Fixed the `@storybook/test` dependency to be listed in
`devDependencies` and not `dependencies`
([#7719](elastic/eui#7719))

## [`v94.2.0`](https://github.com/elastic/eui/releases/v94.2.0)

- Updated `getDefaultEuiMarkdownPlugins()` to allow excluding the
following plugins in addition to `tooltip`:
([#7676](elastic/eui#7676))
  - `checkbox`
  - `linkValidator`
  - `lineBreaks`
  - `emoji`
- Updated `EuiSelectable`'s `isPreFiltered` prop to allow passing a
configuration object, which allows disabling search highlighting in
addition to search filtering
([#7683](elastic/eui#7683))
- Updated `EuiFlexGroup` and `EuiFlexItem` prop types to support passing
any valid React component type to the `component` prop and ensure proper
type checking of the extra props forwarded to the `component`.
([#7688](elastic/eui#7688))
- Updated `EuiSearchBar` to allow the `@` special character in query
string searches ([#7702](elastic/eui#7702))
- Added a new, optional `optionMatcher` prop to `EuiSelectable` and
`EuiComboBox` allowing passing a custom option matcher function to these
components and controlling option filtering for given search string
([#7709](elastic/eui#7709))

**Bug fixes**

- Fixed an `EuiPageTemplate` bug where prop updates would not cascade
down to child sections
([#7648](elastic/eui#7648))
- To cascade props down to the sidebar, `EuiPageTemplate` now explicitly
requires using the `EuiPageTemplate.Sidebar` rather than
`EuiPageSidebar`
- Fixed `EuiFieldNumber`'s typing to accept an icon configuration shape
([#7666](elastic/eui#7666))
- Fixed `EuiFieldText` and `EuiFieldNumber` to render the correct
paddings for icon shapes set to `side: 'right'`
([#7666](elastic/eui#7666))
- Fixed `EuiFieldText` and `EuiFieldNumber` to fully ignore
`icon`/`prepend`/`append` when `controlOnly` is set to true
([#7666](elastic/eui#7666))
- Fixed `EuiColorPicker`'s input not setting the correct right padding
for the number of icons displayed
([#7666](elastic/eui#7666))
- Visual fixes for `EuiRange`s with `showInput`:
([#7678](elastic/eui#7678))
  - Longer `append`/`prepend` labels no longer cause a background bug
  - Inputs can no longer overwhelm the actual range in width
- Fixed a visual text alignment regression in `EuiTableRowCell`s with
the `row` header scope
([#7681](elastic/eui#7681))
- Fixed `toolTipProps` type on `EuiSuperUpdateButton` to use
`Partial<EuiToolTipProps>`
([#7692](elastic/eui#7692))
- Fixes missing prop type for `popperProps` on `EuiDatePicker`
([#7694](elastic/eui#7694))
- Fixed a focus bug with `EuiDataGrid`s with `leadingControlColumns`
when moving columns to the left/right
([#7701](elastic/eui#7701))
([#7698](elastic/eui#7698))
- Fixed `EuiSuperDatePicker` to validate date string with respect of
locale on `EuiAbsoluteTab`.
([#7705](elastic/eui#7705))
- Fixed a visual bug with `EuiSuperDatePicker`'s absolute tab on small
mobile screens ([#7708](elastic/eui#7708))
- Fixed i18n of empty and loading state messages for the
`FieldValueSelectionFilter` component
([#7718](elastic/eui#7718))

**Dependency updates**

- Updated `@hello-pangea/dnd` to v16.6.0
([#7599](elastic/eui#7599))
- Updated `remark-rehype` to v8.1.0
([#7601](elastic/eui#7601))

**Accessibility**

- Improved `EuiBasicTable` and `EuiInMemoryTable`'s selection checkboxes
to have unique aria-labels per row
([#7672](elastic/eui#7672))
- Added `aria-valuetext` attributes to `EuiRange`s with tick labels for
improved screen reader UX
([#7675](elastic/eui#7675))
- Updated `EuiAccordion` to keep focus on accordion trigger instead of
moving to content on click/keypress
([#7696](elastic/eui#7696))
- Added `aria-disabled` attribute to `EuiHorizontalSteps` when status is
"disabled" ([#7699](elastic/eui#7699))

---------

Co-authored-by: Tomasz Kajtoch <tomasz.kajtoch@elastic.co>
mgadewoll pushed a commit to mgadewoll/eui that referenced this pull request May 3, 2024
@cee-chen @mgadewoll
[EuiSearchBar] Allow @ special character in query string searches (e…
bc78c24 
…lastic#7702)
@IanLee1521
Copy link

Great to see this get merged! Do you happen to know what version of Kibana this is expected to land in? 8.14 or 8.15 maybe?

@cee-chen
Copy link
Member Author

cee-chen commented May 6, 2024

8.15. If needed we can backport it to 8.14, but we typically don't do so without a specific request from an Elastic team!

@IanLee1521
Copy link

It's an annoyance, but not something critical. My question was mainly centered around 8.14 not being out and available yet, so I was hoping it would show up there, but you are probably past the feature freeze.

@cee-chen
Copy link
Member Author

cee-chen commented May 7, 2024 •
edited
Loading

Right yes, unfortunately our feature freezes are a good while before the actual release, and this one missed the boat 😬

If you find yourself needing this feature for 8.14, absolutely feel free to escalate it or request it - but if not, we'll see it in 8.15, which will blaze by before you know it!

@cee-chen
Copy link
Member Author

cee-chen commented May 8, 2024

We've received a request from another team for 8.14 backports, so I'll go ahead and add this one to the list as well since we're doing one anyway and since you've raised it!

cee-chen added a commit that referenced this pull request May 8, 2024
@cee-chen
[EuiSearchBar] Allow @ special character in query string searches (#…
0329614 
…7702)
cee-chen added a commit that referenced this pull request May 8, 2024
@cee-chen
[EuiSearchBar] Allow @ special character in query string searches (#…
cba31a5 
…7702)
@cee-chen cee-chen mentioned this pull request May 8, 2024
Merged
cee-chen added a commit to elastic/kibana that referenced this pull request May 8, 2024
@cee-chen @kibanamachine
[8.14] EUI backport with requested fixes (#182972)
c2cd430 
`v93.6.0` ⏩ `v93.6.0-backport.0`

---

##
[`v93.6.0-backport.0`](https://github.com/elastic/eui/releases/v93.6.0-backport.0)

**This is a backport release only intended for use by Kibana.**

- Updated `EuiSearchBar` to allow the `@` special character in query
string searches ([#7702](elastic/eui#7702))

**Bug fixes**

- Fixed a focus bug with `EuiDataGrid`s with `leadingControlColumns`
when moving columns to the left/right
([#7701](elastic/eui#7701))
([#7698](elastic/eui#7698))

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@IanLee1521
Copy link

We've received a request from another team for 8.14 backports, so I'll go ahead and add this one to the list as well since we're doing one anyway and since you've raised it!

Great to hear, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgadewoll mgadewoll mgadewoll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cee-chen @kibanamachine @elasticmachine @IanLee1521 @mgadewoll