-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigating to "Recently viewed" is not working for dashboards when the user comes from the Security solution #166686
Comments
Pinging @elastic/kibana-presentation (Team:Presentation) |
I can confirm on a cloud 8.10.0 cluster. Nothing pops up on the browser dev console (on firefox 117.0.1 (64-bit)) |
This seems to be related to the Dashboard app's locator - the same thing happens when I add a links panel to the security dashboard. Rather than navigating to the specified dashboard in the Dashboard app, I get redirected to the listing page: Screen.Recording.2023-09-19.at.7.56.36.AM.movI can most likely look into this as part of #164748 |
Thanks @Heenawter ! |
After looking into this, it seems as though this may be an issue with the security app's router rather than dashboard's. Basically, when I was looking into this on my own, I found that the I called in @ThomThomson for reinforcements, and we found that at the point of navigation, the dashboard app's hash was already incorrect, which is not the case in any other solution (we tested observability, Discover, management, and a few others - the dashboard router's Screen.Recording.2023-09-19.at.11.38.24.AM.movNote that both "Recent" and links panels are experiencing the exact same bug, so I've demonstrated it with the links panel in the above video but the same applies to navigating through recent. |
Pinging @elastic/security-solution (Team: SecuritySolution) |
Assigning |
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
It's the same bug that causes this issue and #166774 Basically it's x-pack/plugins/security_solution/public/flyout/shared/hooks/url/use_sync_flyout_state_with_url.tsx line 25 syncStateToUrl I'll do a quick fix in #159486 to put the hash back. I'll also ask the team about better way of implementing syncStateToUrl |
@angorayc thank you for looking into this and finding the root cause! |
## Summary This PR fixes the root cause for #166686 and #166774 @angorayc @machadoum ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
## Summary This PR fixes the root cause for elastic#166686 and elastic#166774 @angorayc @machadoum ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit d52c5a1)
…167010) # Backport This will backport the following commits from `main` to `8.10`: - [[Security Solution] Fix missing hash in sync to url (#166847)](#166847) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Luke G","email":"11671118+lgestc@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-09-22T08:23:50Z","message":"[Security Solution] Fix missing hash in sync to url (#166847)\n\n## Summary\r\n\r\nThis PR fixes the root cause for\r\nhttps://github.com//issues/166686 and\r\nhttps://github.com//issues/166774\r\n\r\n@angorayc @machadoum \r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"d52c5a15fdd9e3c8502fbb75378295c5c7649cc6","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Threat Hunting:Investigations","v8.11.0","v8.10.2"],"number":166847,"url":"https://github.com/elastic/kibana/pull/166847","mergeCommit":{"message":"[Security Solution] Fix missing hash in sync to url (#166847)\n\n## Summary\r\n\r\nThis PR fixes the root cause for\r\nhttps://github.com//issues/166686 and\r\nhttps://github.com//issues/166774\r\n\r\n@angorayc @machadoum \r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"d52c5a15fdd9e3c8502fbb75378295c5c7649cc6"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/166847","number":166847,"mergeCommit":{"message":"[Security Solution] Fix missing hash in sync to url (#166847)\n\n## Summary\r\n\r\nThis PR fixes the root cause for\r\nhttps://github.com//issues/166686 and\r\nhttps://github.com//issues/166774\r\n\r\n@angorayc @machadoum \r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"d52c5a15fdd9e3c8502fbb75378295c5c7649cc6"}},{"branch":"8.10","label":"v8.10.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Luke G <11671118+lgestc@users.noreply.github.com>
Issue fixed on 8.11-BC1. |
Kibana version: 8.9 but probably in older versions too
Browser: Chrome
Describe the bug:
When users are located in any of the Security UIs and they click on a recently viewed dashboard from the left bar navigation menu, they get redirected to the dashboard list instead of the dashboard clicked.
This is not happening from other solution UIs (observbability or search) or with other SOs (lens, maps, etc.)
Steps to reproduce:
Expected behavior:
Users should be redirected to the dashboard they clicked.
Screenshots (if relevant):
The text was updated successfully, but these errors were encountered: