-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It wouldn't render when a callByValue visualization navigates to Lens #166774
Comments
x-pack/plugins/security_solution/public/flyout/shared/hooks/url/use_sync_flyout_state_with_url.tsx if you try to open Lens and put a breakpoint at line 27 here: packages/kbn-url-state/use_sync_to_url.ts you will see that the window.location is coming right, but then the hash part is cleaned up
with this you can see that Lens is started with all the correct params, but then the location changes again from /app/lens#/edit_by_value into /app/lens due to that useSyncToUrl hook |
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
Pinging @elastic/security-solution (Team: SecuritySolution) |
From my investigation you reported above it seems the problem is not due to Lens rather to some code that belongs to @elastic/security-solution . I'll remove the |
Root cause: |
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
## Summary This PR fixes the root cause for #166686 and #166774 @angorayc @machadoum ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
## Summary This PR fixes the root cause for elastic#166686 and elastic#166774 @angorayc @machadoum ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit d52c5a1)
…167010) # Backport This will backport the following commits from `main` to `8.10`: - [[Security Solution] Fix missing hash in sync to url (#166847)](#166847) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Luke G","email":"11671118+lgestc@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-09-22T08:23:50Z","message":"[Security Solution] Fix missing hash in sync to url (#166847)\n\n## Summary\r\n\r\nThis PR fixes the root cause for\r\nhttps://github.com//issues/166686 and\r\nhttps://github.com//issues/166774\r\n\r\n@angorayc @machadoum \r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"d52c5a15fdd9e3c8502fbb75378295c5c7649cc6","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Threat Hunting:Investigations","v8.11.0","v8.10.2"],"number":166847,"url":"https://github.com/elastic/kibana/pull/166847","mergeCommit":{"message":"[Security Solution] Fix missing hash in sync to url (#166847)\n\n## Summary\r\n\r\nThis PR fixes the root cause for\r\nhttps://github.com//issues/166686 and\r\nhttps://github.com//issues/166774\r\n\r\n@angorayc @machadoum \r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"d52c5a15fdd9e3c8502fbb75378295c5c7649cc6"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/166847","number":166847,"mergeCommit":{"message":"[Security Solution] Fix missing hash in sync to url (#166847)\n\n## Summary\r\n\r\nThis PR fixes the root cause for\r\nhttps://github.com//issues/166686 and\r\nhttps://github.com//issues/166774\r\n\r\n@angorayc @machadoum \r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"d52c5a15fdd9e3c8502fbb75378295c5c7649cc6"}},{"branch":"8.10","label":"v8.10.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Luke G <11671118+lgestc@users.noreply.github.com>
Edit.Existing.mp4
After calling
this.stateTransfer.navigateToEditor
in src/plugins/embeddable/public/embeddable_panel/panel_actions/edit_panel_action/edit_panel_action.ts line 105When
Edit Lens
from a visualization in Analytic > dashboard,Lens app will have the correct breadcrumb
Edit ...
, as it has thepersistedDoc
value.When
Edit Lens
from a visualization in Security Solution > dashboard,Lens app always has the
Security > Create
breadcrumbs, and it has nopersistedDoc
value.The persistedDoc value matches the visualization we clicked in the dashboard, but Lens wouldn't have it after leaving from SecuritySolution
Originally posted by @angorayc in #159486 (comment)
The text was updated successfully, but these errors were encountered: