-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] Fix missing hash in sync to url #166847
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix 👍
9feebfe
to
6a6828a
Compare
6a6828a
to
5352b0f
Compare
080d931
to
557a5cb
Compare
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for putting the fix in @lgestc
## Summary This PR fixes the root cause for elastic#166686 and elastic#166774 @angorayc @machadoum ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit d52c5a1)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…167010) # Backport This will backport the following commits from `main` to `8.10`: - [[Security Solution] Fix missing hash in sync to url (#166847)](#166847) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Luke G","email":"11671118+lgestc@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-09-22T08:23:50Z","message":"[Security Solution] Fix missing hash in sync to url (#166847)\n\n## Summary\r\n\r\nThis PR fixes the root cause for\r\nhttps://github.com//issues/166686 and\r\nhttps://github.com//issues/166774\r\n\r\n@angorayc @machadoum \r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"d52c5a15fdd9e3c8502fbb75378295c5c7649cc6","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Threat Hunting:Investigations","v8.11.0","v8.10.2"],"number":166847,"url":"https://github.com/elastic/kibana/pull/166847","mergeCommit":{"message":"[Security Solution] Fix missing hash in sync to url (#166847)\n\n## Summary\r\n\r\nThis PR fixes the root cause for\r\nhttps://github.com//issues/166686 and\r\nhttps://github.com//issues/166774\r\n\r\n@angorayc @machadoum \r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"d52c5a15fdd9e3c8502fbb75378295c5c7649cc6"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/166847","number":166847,"mergeCommit":{"message":"[Security Solution] Fix missing hash in sync to url (#166847)\n\n## Summary\r\n\r\nThis PR fixes the root cause for\r\nhttps://github.com//issues/166686 and\r\nhttps://github.com//issues/166774\r\n\r\n@angorayc @machadoum \r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"d52c5a15fdd9e3c8502fbb75378295c5c7649cc6"}},{"branch":"8.10","label":"v8.10.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Luke G <11671118+lgestc@users.noreply.github.com>
Summary
This PR fixes the root cause for #166686 and #166774
@angorayc @machadoum
Checklist
Delete any items that are not applicable to this PR.