Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workplace Search] Fix Media Type field preview is unformatted bug #104684

Merged

Conversation

scottybollinger
Copy link
Contributor

@scottybollinger scottybollinger commented Jul 7, 2021

fixes https://github.com/elastic/workplace-search-team/issues/1780

Summary

This is a port of https://github.com/elastic/ent-search/pull/4004 to Kibana

Checklist

@scottybollinger scottybollinger added release_note:skip Skip the PR/issue when compiling release notes v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Jul 7, 2021
@scottybollinger scottybollinger requested a review from a team July 7, 2021 15:39
@scottybollinger scottybollinger enabled auto-merge (squash) July 7, 2021 15:41
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
enterpriseSearch 1443 1444 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.1MB 2.1MB +1.8KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@scottybollinger scottybollinger merged commit b20669e into elastic:master Jul 7, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 7, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 7, 2021
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.14
7.x

The backport PRs will be merged automatically after passing CI.

@scottybollinger scottybollinger deleted the scottybollinger/mime-fix branch July 7, 2021 18:09
kibanamachine added a commit that referenced this pull request Jul 7, 2021
…104684) (#104725)

* Add mimeTypes util

* Properly format mimeTypes

Co-authored-by: Scotty Bollinger <scotty.bollinger@elastic.co>
kibanamachine added a commit that referenced this pull request Jul 7, 2021
…104684) (#104726)

* Add mimeTypes util

* Properly format mimeTypes

Co-authored-by: Scotty Bollinger <scotty.bollinger@elastic.co>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jul 8, 2021
…-of-max-results

* 'master' of github.com:elastic/kibana: (36 commits)
  Lower Kibana app bundle limits (elastic#104688)
  [Security Solutions] Fixes bug with the filter query compatibility for transforms (elastic#104559)
  [RAC] Add mapping update logic to RuleDataClient (elastic#102586)
  Fix import workpad (elastic#104722)
  [canvas] Fix Storybook service decorator (elastic#104750)
  [Detection Rules] Add 7.14 rules (elastic#104772)
  [Enterprise Search] Fix beta notification in sidebar (elastic#104763)
  Fix engine routes that are meta engine or non-meta-engine specific (elastic#104757)
  [Fleet] Fix policy revision number getting bumped for no reason (elastic#104696)
  persistable state migrations (elastic#103680)
  [Fleet] Fix add agent in the package policy table (elastic#104749)
  [DOCS] Creates separate doc for security in production (elastic#103973)
  [SO Migration] fix reindex race on multi-instance mode (elastic#104516)
  [Security Solution] Update text in Endpoint Admin pages (elastic#104649)
  [package testing] Decrease timeout to 2 hours (elastic#104668)
  Fix background styling of waterfall chart sidebar tooltip. (elastic#103997)
  [Fleet + Integrations UI] Integrations UI Cleanup (elastic#104641)
  [Fleet] Link to download page of current stack version on Agent install instructions (elastic#104494)
  [Workplace Search] Fix Media Type field preview is unformatted bug (elastic#104684)
  [ML] add marker body (elastic#104672)
  ...

# Conflicts:
#	x-pack/plugins/fleet/public/search_provider.test.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v7.14.0 v7.15.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants