[i18n] .i18nrc file as the source of truth and enhance tooling #39774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bamieh
added
Project:i18n
release_note:plugin_api_changes
💔 Build Failed |
💔 Build Failed |
|
retest |
spalger
reviewed
Jun 27, 2019
💔 Build Failed |
spalger
reviewed
Jun 27, 2019
There was a problem hiding this comment.
I'm going to defer to @azasypkin here, since I'm not super familiar with the i18n stuff, but I do remember us pretty explicitly wanting the translations to not require a config file to find and instead that we wanted to use consistent paths. Not saying we can't change course, but I want to make sure it's well considered and I don't think I have enough context to do so.
|
@spalger Sounds good. I did had a chat with Oleg while working on this, lets wait for his feedback. |
bmcconaghy
approved these changes
Jun 27, 2019
| @@ -324,3 +324,8 @@ export class ErrorReporter { | |||
| ); | |||
| } | |||
| } | |||
|
|
|||
| // export function arrayify<Subj = any>(subj: Subj | Subj[]): Subj[] { | |||
There was a problem hiding this comment.
Why is there commented out code here? Did you start typescripting this file and then stop?
There was a problem hiding this comment.
I left it for whenever we want to mvoe this file to TS
💔 Build Failed |
|
retest |
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
eliperelman
approved these changes
Jul 9, 2019
💚 Build Succeeded |
spalger
approved these changes
Jul 10, 2019
… into i18n/packages-translations
💔 Build Failed |
💚 Build Succeeded |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jul 22, 2019
…b-panel-for-stopping-jobs * 'master' of github.com:elastic/kibana: (58 commits) [DOCS] Timelion cleanup (elastic#41381) [Docs] Add simple phrase highlighting to Logs UI (elastic#41610) [Maps] Rename modules for clarity (elastic#41608) [Monitoring] Metricbeat migration net new user experience (elastic#39832) [Maps] Only color legend icon with dynamic color when dynamic config is complete (elastic#41607) [TSVB] [Markdown] markdown section do not render after change data parameter (elastic#41576) [Vega] (Step 2) Shim new platform - renaming vega -> vis_type_vega (elastic#41565) update dark mode tsvb test (elastic#41618) [i18n] .i18nrc file as the source of truth and enhance tooling (elastic#39774) Reactify Top Nav Menu (kbn_top_nav) (elastic#40262) fix(code/frontend): should update search results if search options change (elastic#41232) Use kibana-ci-proxy-cache for chrome and gecko drivers (elastic#41581) [SIEM] Fix draggables to work with escapeId for the ML severity column (elastic#41621) [Canvas] Updates esdocs default count to 1000 (elastic#41604) [Uptime] Fix duration chart for Safari (elastic#41619) [Canvas] Restores "Today" as a quick time range in time filter (elastic#41528) docs: lowercase app (elastic#41612) [Code] Update git repository update frequency (elastic#41541) Remove language=json on code blocks due to performance hit (elastic#41540) [DOCS] Update anchors and links for Elasticserach API relocation. (elastic#41372) ...
|
@Bamieh - has this been backported to 7.4? |
|
@stacey-gammon oh! PR submitted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dev Docs
Currently there is a disconnect disconnect between i18n tooling (
i18nrc.json) andtop-level/translationsconvention used by the kibanai18nservice. This change attempts to fix it, tidying up the code a little, and enhancing the i18n tooling as a result of this change.Use
.i18nrc.jsonas the source of truthCurrently we assume that internal and external plugins to follow this convention of putting translations following this pattern
**/*/translations/${locale}.json.We also have to keep the
.i18nrcin sync with the location of each of these translation files.This change makes the
i18nservice look into top level.i18nrc.jsonfiles and parses thetranslationsinstead of traversing the source code directories to look for translation files.This change discards the translation paths assumptions and allows developers to explicitly specify translation paths inside
.i18nrcfile. Previously thetranslationspaths in the.i18nrcwas only used for thescripts/i18n_check.jstooling.This change also allows for a better third party plugin development experience as developers can fully control their own translation paths using the
.i18nrc.jsonfile.Enhance i18n tooling (namespaces prefix checking, better logging and error handling for parsing
.i18nrcfiles)Introducing top level
.i18nrcfiles for plugins allows adding a namespacesprefixcheck.This PR adds a prefix check that all
x-packplugin namespaces (label ids) start withxpack.*Introducing top level
.i18nrcfiles for plugins allows for a better experience in merging configs. This PR adds a more verbose logging while merging configs and better error handling.