Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Uptime] Fix duration chart for Safari #41619

Merged

Conversation

justinkambic
Copy link
Contributor

Summary

Currently, in the Safari browser the duration chart does not appear. This is because we didn't specify an explicit height for its container panel component. This change adds an explicit height.

Testing

  1. Check out this PR, run it against ES and Heartbeat with at least one monitor
  2. Navigate to the Uptime UI
  3. Select your monitor and navigate to the Monitor page
  4. Ensure the duration line series chart is visible in the left-hand side of the view

@justinkambic justinkambic added bug Fixes for quality problems that affect the customer experience v8.0.0 Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.3.0 v7.4.0 labels Jul 19, 2019
@justinkambic justinkambic self-assigned this Jul 19, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime

@andrewvc andrewvc added the release_note:skip Skip the PR/issue when compiling release notes label Jul 19, 2019
Copy link
Contributor

@andrewvc andrewvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@justinkambic justinkambic merged commit 1b9df0b into elastic:master Jul 19, 2019
@justinkambic justinkambic added release_note:fix and removed release_note:skip Skip the PR/issue when compiling release notes labels Jul 19, 2019
justinkambic added a commit to justinkambic/kibana that referenced this pull request Jul 22, 2019
* Add height to a panel that was causing a chart not to show in the Safari browser.

* Prefer string with explicit units for panel style.
justinkambic added a commit to justinkambic/kibana that referenced this pull request Jul 22, 2019
* Add height to a panel that was causing a chart not to show in the Safari browser.

* Prefer string with explicit units for panel style.
justinkambic added a commit that referenced this pull request Jul 22, 2019
* Add height to a panel that was causing a chart not to show in the Safari browser.

* Prefer string with explicit units for panel style.
@justinkambic
Copy link
Contributor Author

justinkambic commented Jul 22, 2019

justinkambic added a commit that referenced this pull request Jul 22, 2019
* Add height to a panel that was causing a chart not to show in the Safari browser.

* Prefer string with explicit units for panel style.
@justinkambic justinkambic deleted the uptime_duration-container-height branch July 22, 2019 13:47
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jul 22, 2019
…b-panel-for-stopping-jobs

* 'master' of github.com:elastic/kibana: (58 commits)
  [DOCS] Timelion cleanup (elastic#41381)
  [Docs] Add simple phrase highlighting to Logs UI (elastic#41610)
  [Maps] Rename modules for clarity (elastic#41608)
  [Monitoring] Metricbeat migration net new user experience (elastic#39832)
  [Maps] Only color legend icon with dynamic color when dynamic config is complete (elastic#41607)
  [TSVB] [Markdown] markdown section do not render after change data parameter (elastic#41576)
  [Vega] (Step 2) Shim new platform - renaming vega -> vis_type_vega (elastic#41565)
  update dark mode tsvb test (elastic#41618)
  [i18n] .i18nrc file as the source of truth and enhance tooling (elastic#39774)
  Reactify Top Nav Menu (kbn_top_nav) (elastic#40262)
  fix(code/frontend): should update search results if search options change (elastic#41232)
  Use kibana-ci-proxy-cache for chrome and gecko drivers (elastic#41581)
  [SIEM] Fix draggables to work with escapeId for the ML severity column (elastic#41621)
  [Canvas] Updates esdocs default count to 1000 (elastic#41604)
  [Uptime] Fix duration chart for Safari (elastic#41619)
  [Canvas] Restores "Today" as a quick time range in time filter (elastic#41528)
  docs: lowercase app (elastic#41612)
  [Code] Update git repository update frequency (elastic#41541)
  Remove language=json on code blocks due to performance hit (elastic#41540)
  [DOCS] Update anchors and links for Elasticserach API relocation. (elastic#41372)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience release_note:fix Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.3.0 v7.4.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants