-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Uptime] Fix duration chart for Safari #41619
Merged
justinkambic
merged 2 commits into
elastic:master
from
justinkambic:uptime_duration-container-height
Jul 19, 2019
Merged
[Uptime] Fix duration chart for Safari #41619
justinkambic
merged 2 commits into
elastic:master
from
justinkambic:uptime_duration-container-height
Jul 19, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinkambic
added
bug
Fixes for quality problems that affect the customer experience
v8.0.0
Team:Uptime - DEPRECATED
Synthetics & RUM sub-team of Application Observability
v7.3.0
v7.4.0
labels
Jul 19, 2019
Pinging @elastic/uptime |
andrewvc
added
the
release_note:skip
Skip the PR/issue when compiling release notes
label
Jul 19, 2019
andrewvc
approved these changes
Jul 19, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💚 Build Succeeded |
justinkambic
added
release_note:fix
and removed
release_note:skip
Skip the PR/issue when compiling release notes
labels
Jul 19, 2019
justinkambic
added a commit
to justinkambic/kibana
that referenced
this pull request
Jul 22, 2019
* Add height to a panel that was causing a chart not to show in the Safari browser. * Prefer string with explicit units for panel style.
justinkambic
added a commit
to justinkambic/kibana
that referenced
this pull request
Jul 22, 2019
* Add height to a panel that was causing a chart not to show in the Safari browser. * Prefer string with explicit units for panel style.
justinkambic
added a commit
that referenced
this pull request
Jul 22, 2019
Backported to: |
justinkambic
added a commit
that referenced
this pull request
Jul 22, 2019
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jul 22, 2019
…b-panel-for-stopping-jobs * 'master' of github.com:elastic/kibana: (58 commits) [DOCS] Timelion cleanup (elastic#41381) [Docs] Add simple phrase highlighting to Logs UI (elastic#41610) [Maps] Rename modules for clarity (elastic#41608) [Monitoring] Metricbeat migration net new user experience (elastic#39832) [Maps] Only color legend icon with dynamic color when dynamic config is complete (elastic#41607) [TSVB] [Markdown] markdown section do not render after change data parameter (elastic#41576) [Vega] (Step 2) Shim new platform - renaming vega -> vis_type_vega (elastic#41565) update dark mode tsvb test (elastic#41618) [i18n] .i18nrc file as the source of truth and enhance tooling (elastic#39774) Reactify Top Nav Menu (kbn_top_nav) (elastic#40262) fix(code/frontend): should update search results if search options change (elastic#41232) Use kibana-ci-proxy-cache for chrome and gecko drivers (elastic#41581) [SIEM] Fix draggables to work with escapeId for the ML severity column (elastic#41621) [Canvas] Updates esdocs default count to 1000 (elastic#41604) [Uptime] Fix duration chart for Safari (elastic#41619) [Canvas] Restores "Today" as a quick time range in time filter (elastic#41528) docs: lowercase app (elastic#41612) [Code] Update git repository update frequency (elastic#41541) Remove language=json on code blocks due to performance hit (elastic#41540) [DOCS] Update anchors and links for Elasticserach API relocation. (elastic#41372) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Fixes for quality problems that affect the customer experience
release_note:fix
Team:Uptime - DEPRECATED
Synthetics & RUM sub-team of Application Observability
v7.3.0
v7.4.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, in the Safari browser the duration chart does not appear. This is because we didn't specify an explicit height for its container panel component. This change adds an explicit height.
Testing